Skip to content

Improve configuration managements #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linuxchata merged 1 commit into from
Feb 11, 2026
Merged

Improve configuration managements #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Shark.AuthorizationServer.Sdk/Extensions/ApplicationBuilderExtentions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,16 @@ public static IServiceCollection AddSharkAuthentication(
.AddAuthentication(Scheme.Bearer)
.AddScheme<BearerTokenAuthenticationOptions, BearerTokenAuthenticationHandler>(
Scheme.Bearer,
options => options = bearerTokenAuthenticationOptions);
options =>
{
options.AuthorizationServerUri = bearerTokenAuthenticationOptions.AuthorizationServerUri;
options.Issuer = bearerTokenAuthenticationOptions.Issuer;
options.ValidateIssuer = bearerTokenAuthenticationOptions.ValidateIssuer;
options.Audience = bearerTokenAuthenticationOptions.Audience;
options.ValidateAudience = bearerTokenAuthenticationOptions.ValidateAudience;
options.TokenIntrospection = bearerTokenAuthenticationOptions.TokenIntrospection;
options.RetryConfiguration = bearerTokenAuthenticationOptions.RetryConfiguration;
});

return services;
}
Expand Down
13 changes: 2 additions & 11 deletions src/Shark.AuthorizationServer/Extensions/ApplicationBuilderExtentions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,6 @@ private static IServiceCollection AddCustomAuthentication(
services.Configure<AuthorizationServerSecurityConfiguration>(
configuration.GetSection(AuthorizationServerSecurityConfiguration.Name));

var authorizationServerConfiguration = new AuthorizationServerConfiguration();
configuration.GetSection(AuthorizationServerConfiguration.Name).Bind(authorizationServerConfiguration);

var basicAuthenticationOptions = new BasicAuthenticationOptions();
configuration.GetSection(BasicAuthenticationOptions.Name).Bind(basicAuthenticationOptions);

var clientTokenAuthenticationOptions = new ClientTokenAuthenticationOptions();
configuration.GetSection(ClientTokenAuthenticationOptions.Name).Bind(clientTokenAuthenticationOptions);

// Authentication session (cookie).
// Cookies scheme is used to extract user identity from authentication cookies.
// However, None scheme is used to support non-browser-based flows (without user).
Expand All @@ -80,7 +71,7 @@ private static IServiceCollection AddCustomAuthentication(
.AddAuthentication(Scheme.Basic)
.AddScheme<BasicAuthenticationOptions, BasicAuthenticationHandler>(
Scheme.Basic,
options => options = basicAuthenticationOptions);
options => { });

services
.AddAuthorizationBuilder()
Expand All @@ -92,7 +83,7 @@ private static IServiceCollection AddCustomAuthentication(
.AddAuthentication(Scheme.ClientToken)
.AddScheme<ClientTokenAuthenticationOptions, ClientTokenAuthenticationHandler>(
Scheme.ClientToken,
options => options = clientTokenAuthenticationOptions);
options => { });

// Bearer token authentication.
services.AddTransient<ISecurityKeyProvider, SecurityKeyLocalProvider>();
Expand Down