fix: 解决新装镜像创建用户后出现开机音效服务启动失败的问题

[fly602]

创建用户时，lightdm已经启动了，这时候还没有用户，开机音效服务获取不到用户信息，导致运行报错。改成脚本执行，忽略报错。

Log: 开机音效服务中的二进制改成脚本执行，忽略运行报错
PMS: BUG-332437
Influence: login-sound.service

Summary by Sourcery

Prevent login sound service from failing on new installations by invoking it through a script that ignores errors and updating the D-Bus interface names

Bug Fixes:

• Invoke the login-sound service via a script that silences execution errors when no user is available
• Update D-Bus destination and object path in deepin-boot-sound.sh to the correct SoundThemePlayer interface

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR replaces the direct D-Bus binary call in the login-sound service with a wrapper script that ignores errors when no user exists, and updates that script to use the correct D-Bus interface paths.

File-Level Changes

Change	Details	Files
Switch login-sound service to invoke the wrapper script and tolerate failures	Replaced direct ExecStart binary call with deepin-boot-sound.sh Configured the service to ignore script failures (e.g. adding failure tolerance)	misc/systemd/system/deepin-login-sound.service
Adjust D-Bus destination and object path in the boot-sound script	Updated D-Bus destination from com.deepin.api.SoundThemePlayer to org.deepin.dde.SoundThemePlayer1 Changed object path to /org/deepin/dde/SoundThemePlayer1	misc/scripts/deepin-boot-sound.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-bot]

TAG Bot

New tag: 6.0.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #156

[deepin-ci-robot]

deepin pr auto review

我来对这段代码进行审查，主要关注语法逻辑、代码质量、性能和安全性。

语法逻辑分析

1. deepin-boot-sound.sh 文件的变更：

   • 将 D-Bus 目标从 com.deepin.api.SoundThemePlayer 更改为 org.deepin.dde.SoundThemePlayer1
   • 将接口从 com.deepin.api.SoundThemePlayer.PlaySoundDesktopLogin 更改为 org.deepin.dde.SoundThemePlayer1.PlaySoundDesktopLogin
   • 保留了后台执行符 &

2. deepin-login-sound.service 文件的变更：

   • 将 ExecStart 从直接调用 dbus-send 更改为执行脚本 /usr/lib/deepin-api/deepin-boot-sound.sh
   • 保留了其他配置如 Type、User、SupplementaryGroups 等

代码质量评估

1. 改进点：

   • 将直接调用 D-Bus 命令改为通过脚本封装，提高了代码的可维护性和可读性
   • 使用了专门的 deepin-boot-sound.sh 脚本，使功能更加模块化

2. 潜在问题：

   • deepin-boot-sound.sh 脚本中仍然使用了后台执行符 &，这在 systemd 服务中可能不是最佳实践
   • 脚本路径从 /usr/bin/ 改为 /usr/lib/deepin-api/，需要确保这个路径存在且可执行

性能考虑

1. 后台执行符 & 的使用可能导致脚本执行顺序不确定，对于启动声音这种需要按顺序执行的操作可能不合适
2. 使用 systemd 服务管理启动声音比直接通过 D-Bus 调用更加规范，有利于资源管理和生命周期控制

安全性评估

1. 正面方面：

   • 使用了专门的 deepin-daemon 用户运行服务，降低了权限风险
   • 添加了 audio 附属组，确保有必要的音频播放权限
   • 设置了 DevicePolicy=closed，限制了设备访问权限

2. 安全隐患：

   • 脚本路径变更需要确保新路径的安全性，避免路径遍历攻击
   • 后台执行可能导致竞态条件，特别是在系统启动过程中
   • 需要确保脚本有适当的权限设置，避免被非授权用户修改

改进建议

1. 移除脚本中的后台执行符 &，让 systemd 服务管理执行过程
2. 在脚本中添加错误处理和日志记录，便于问题排查
3. 确保脚本路径的安全性，设置适当的文件权限
4. 考虑添加环境变量检查，确保必要的服务可用
5. 可以在脚本中添加参数验证，确保调用参数的正确性

改进后的脚本示例：

#!/bin/sh

# 检必要的环境变量
if [ -z "$XDG_RUNTIME_DIR" ]; then
    export XDG_RUNTIME_DIR="/run/user/$(id -u deepin-daemon)"
fi

# 记录日志
logger "Starting deepin boot sound"

# 执行 D-Bus 调用
/usr/bin/dbus-send --system --print-reply \
    --dest=org.deepin.dde.SoundThemePlayer1 \
    /org/deepin/dde/SoundThemePlayer1 \
    org.deepin.dde.SoundThemePlayer1.PlaySoundDesktopLogin

# 检查执行结果
if [ $? -ne 0 ]; then
    logger "Failed to play boot sound"
    exit 1
fi

exit 0

这些建议可以提高代码的健壮性、安全性和可维护性。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-bot]

TAG Bot

New tag: 6.0.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #157