Skip to content

feat: [kvm] support xwayland#415

Merged
re2zero merged 1 commit intolinuxdeepin:masterfrom
pppanghu77:master
May 14, 2024
Merged

feat: [kvm] support xwayland#415
re2zero merged 1 commit intolinuxdeepin:masterfrom
pppanghu77:master

Conversation

@pppanghu77
Copy link
Contributor

[kvm] support xwayland

Log: [kvm] support xwayland

Copy link
Contributor

@re2zero re2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用宏隔离


#include "XWindowsScreen.h"
#include "base/Log.h"
#include <displayjack_kvm.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"displayjack_kvm/displayjack_kvm.h"

elseif (UNIX)
file(GLOB headers "XWindows*.h")
file(GLOB sources "XWindows*.cpp")
file(GLOB sources "XWindows*.cpp" "wayland*.h")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用宏独立出来

Comment on lines +43 to +45
include_directories(/usr/include/displayjack_kvm/)
link_directories(/usr/lib/x86_64-linux-gnu/)
target_link_libraries(platform io net ipc synlib client ${libs} displayjack_kvm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要额外引入

re2zero
re2zero previously approved these changes May 7, 2024
@deepin-bot
Copy link

deepin-bot bot commented May 13, 2024

TAG Bot

New tag: 0.7.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #418

 [kvm] support xwayland

Log: [kvm] support xwayland
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • XWindowsScreen::handleMouseMove方法中,确认是否有必要在每次鼠标移动时都调用onMouseMove方法,这可能会影响性能。
  • WaylandUtils::isWayland方法的实现中使用了getenv,这可能会导致在某些情况下环境变量未设置时返回false,而不是true
  • WaylandUtils::set_pointer_pos方法直接使用了kvm_pointer_set_pos函数,但没有检查其返回值,可能会忽略错误。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pppanghu77, re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero re2zero merged commit 4544639 into linuxdeepin:master May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants