fix: Fix crash issue if network disconnected.#626
fix: Fix crash issue if network disconnected.#626re2zero merged 2 commits intolinuxdeepin:masterfrom
Conversation
When device item update after network disconnected, it crashed. Log: Fix crash issue if network disconnected. Bug: https://pms.uniontech.com/bug-view-311269.html
Reviewer's Guide by SourceryThis pull request addresses a crash that occurred when updating device items after a network disconnection. The fix involves adding checks for widget visibility before updating operations and performing necessary cleanup in the destructor. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @re2zero - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider preventing calls to
updateOperationsentirely when the device item is removed or disconnected, rather than checking visibility within the function.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
v1.1.2 release. Log: New tag v1.1.2
deepin pr auto review代码审查意见:
总体来说,代码修改看起来是合理的,但需要进一步确认新增的 |
|
TAG Bot TAG: 1.1.2 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
When device item update after network disconnected, it crashed.
Log: Fix crash issue if network disconnected.
Bug: https://pms.uniontech.com/bug-view-311269.html
Summary by Sourcery
Prevent crash in DeviceItem when network disconnects during operation update.
Bug Fixes: