Skip to content

chore: [tag] New tag v1.1.3#627

Merged
re2zero merged 1 commit intolinuxdeepin:masterfrom
re2zero:bugfix
May 19, 2025
Merged

chore: [tag] New tag v1.1.3#627
re2zero merged 1 commit intolinuxdeepin:masterfrom
re2zero:bugfix

Conversation

@re2zero
Copy link
Contributor

@re2zero re2zero commented May 19, 2025

Fix start avahi service failed issue and v1.1.3 release.

Log: v1.1.3 release.

Summary by Sourcery

Tag a new release v1.1.3 and resolve the issue where starting the avahi-daemon service failed

Bug Fixes:

  • Adjust QProcess::startDetached call to pass arguments separately when starting avahi-daemon.service

Chores:

  • Add v1.1.3 entry to the Debian changelog and bump the release tag

Fix start avahi service failed issue and v1.1.3 release.

Log: v1.1.3 release.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • discovercontroller.cpp文件中,QProcess::startDetached函数的参数列表已经正确地使用QStringList,这是一个好的做法,因为它可以避免潜在的字符串拼接错误。

是否建议立即修改:

  • 否,这次提交的修改是正确的,没有发现需要立即修改的问题。

@github-actions
Copy link

TAG Bot

TAG: 1.1.3
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @re2zero - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented May 19, 2025

Reviewer's Guide

Fixes avahi-daemon startup by switching to the QProcess::startDetached overload that takes a program and argument list, and updates the Debian changelog for the v1.1.3 release.

Sequence Diagram: Corrected Avahi-Daemon Service Startup

sequenceDiagram
    actor User
    participant DiscoverController
    participant QProcess
    participant System_OS as OS/systemctl

    User->>+DiscoverController: Confirms enabling LAN discovery (dialog)
    DiscoverController->>QProcess: call static startDetached("systemctl", ["start", "avahi-daemon.service"])
    QProcess->>System_OS: Execute systemctl start avahi-daemon.service
    System_OS-->>QProcess: Process started
    QProcess-->>DiscoverController: Returns (detached)
    DiscoverController-->>-User: LAN discovery service starting
Loading

File-Level Changes

Change Details Files
Use QProcess::startDetached overload for systemctl invocation
  • Replace single-string command with program+args invocation
  • Pass “start” and “avahi-daemon.service” as separate arguments
src/lib/cooperation/core/discover/discovercontroller.cpp
Update Debian changelog for v1.1.3 release
  • Bump version tag to v1.1.3
  • Add release log entry
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero re2zero merged commit 2fb6497 into linuxdeepin:master May 19, 2025
15 of 17 checks passed
@re2zero re2zero deleted the bugfix branch May 19, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants