Merged
Conversation
Reviewer's GuideThis pull request adds comprehensive Lao language translation files for the Cooperation and Data Transfer applications, their file-manager plugins, and associated desktop entries to enable lo locale support. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JWWTSL - I've reviewed your changes - here's some feedback:
- Consider splitting this massive translation update into separate PRs per component (e.g., dde-cooperation, data-transfer, desktop entries) to make reviews more manageable.
- Double-check that all new strings have been correctly translated or marked as “unfinished”—I spotted several entries still blank or flagged as unfinished.
- Verify that placeholders (like %1, %2) and XML entities are preserved exactly in each translation to avoid runtime formatting errors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider splitting this massive translation update into separate PRs per component (e.g., dde-cooperation, data-transfer, desktop entries) to make reviews more manageable.
- Double-check that all new strings have been correctly translated or marked as “unfinished”—I spotted several entries still blank or flagged as unfinished.
- Verify that placeholders (like %1, %2) and XML entities are preserved exactly in each translation to avoid runtime formatting errors.
## Individual Comments
### Comment 1
<location> `translations/deepin-data-transfer/deepin-data-transfer_lo.ts:358` </location>
<code_context>
+ <message>
+ <location filename="../../src/plugins/data-transfer/core/gui/select/fileselectwidget.cpp" line="71"/>
+ <source>Cancel</source>
+ <translation>Batalkan</translation>
+ </message>
+ <message>
</code_context>
<issue_to_address>
Inconsistent language for 'Cancel' translation.
'Batalkan' is Indonesian. Please update the translation to match the file's target language.
</issue_to_address>
### Comment 2
<location> `translations/deepin-data-transfer/deepin-data-transfer_lo.ts:445` </location>
<code_context>
+ <message>
+ <location filename="../../src/plugins/data-transfer/core/gui/connect/readywidget.cpp" line="59"/>
+ <source>Please input the IP of UOS</source>
+ <translation>ກະລົດປ້ອມກະລົນ IP ຂອງ UOS</translation>
+ </message>
+ <message>
</code_context>
<issue_to_address>
Inconsistent use of 'ກະລົດປ້ອມກະລົນ' in multiple translations.
Please check if this phrase is accurate and appropriate in each translation context.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<location filename="../../src/plugins/data-transfer/core/gui/connect/readywidget.cpp" line="59"/>
<source>Please input the IP of UOS</source>
<translation>ກະລົດປ້ອມກະລົນ IP ຂອງ UOS</translation>
=======
<location filename="../../src/plugins/data-transfer/core/gui/connect/readywidget.cpp" line="59"/>
<source>Please input the IP of UOS</source>
<translation>ກະລຸນາປ້ອນ IP ຂອງ UOS</translation>
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <message> | ||
| <location filename="../../src/plugins/data-transfer/core/gui/select/fileselectwidget.cpp" line="71"/> | ||
| <source>Cancel</source> | ||
| <translation>Batalkan</translation> |
There was a problem hiding this comment.
issue: Inconsistent language for 'Cancel' translation.
'Batalkan' is Indonesian. Please update the translation to match the file's target language.
Comment on lines
+443
to
+445
| <location filename="../../src/plugins/data-transfer/core/gui/connect/readywidget.cpp" line="59"/> | ||
| <source>Please input the IP of UOS</source> | ||
| <translation>ກະລົດປ້ອມກະລົນ IP ຂອງ UOS</translation> |
There was a problem hiding this comment.
suggestion: Inconsistent use of 'ກະລົດປ້ອມກະລົນ' in multiple translations.
Please check if this phrase is accurate and appropriate in each translation context.
Suggested change
| <location filename="../../src/plugins/data-transfer/core/gui/connect/readywidget.cpp" line="59"/> | |
| <source>Please input the IP of UOS</source> | |
| <translation>ກະລົດປ້ອມກະລົນ IP ຂອງ UOS</translation> | |
| <location filename="../../src/plugins/data-transfer/core/gui/connect/readywidget.cpp" line="59"/> | |
| <source>Please input the IP of UOS</source> | |
| <translation>ກະລຸນາປ້ອນ IP ຂອງ UOS</translation> |
|
TAG Bot TAG: 1.1.15 |
lzwind
approved these changes
Aug 8, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log:
Summary by Sourcery
Add Lao locale translations across multiple Deepin components
Enhancements: