feat(power)!: switch backend from lmt to tlp by Decodetalkers · Pull Request #559 · linuxdeepin/dde-daemon

Decodetalkers · 2023-09-25T03:38:45Z

Log:

Decodetalkers · 2023-09-26T01:52:57Z

dengbo11 · 2023-09-28T01:11:07Z

system/power1/manager_bluetoothadapter.go

+	"os/exec"
+	"regexp"
+	"strings"
+)


添加空行，下面几处同理

dengbo11 · 2023-09-28T01:16:57Z

system/power1/manager_powersave.go

+		return
+	}
+	var enable bool
+	// var tlpCfgChanged bool


不需要的变量删掉

dengbo11 · 2023-09-28T01:21:41Z

system/power1/manager_tlp.go

+	"os/exec"
+	"path/filepath"
+	"strings"
+	//"github.com/linuxdeepin/go-lib/dbusutil"


不需要的包删掉

dengbo11 · 2023-09-28T01:23:55Z

system/power1/manager_tlp.go

+		if os.IsNotExist(err) {
+			return false, nil
+		}
+		logger.Warning(err)


这一行可以移到65行

dengbo11 · 2023-09-28T01:31:33Z

system/power1/manager.go

 }
+
+func (m *Manager) setPowerSavingModeEnabled(enable bool) (changed bool) {
+	changed = m.setPropPowerSavingModeEnabled(enable)


如果这个属性没有change, 是否还需要写呢

dengbo11 · 2023-09-28T01:41:14Z

system/power1/manager_powersave.go

+import (
+	"errors"
+	"github.com/godbus/dbus/v5"
+	ConfigManager "github.com/linuxdeepin/go-dbus-factory/org.desktopspec.ConfigManager"


ConfigManager小写命名

dengbo11 · 2023-09-28T01:49:09Z

system/power1/manager.go

 		}

-		m.setPropPowerSavingModeEnabled(false)
+		m.setPowerSavingModeEnabled(false)


这里是否需要加锁，下面两处同理

嗯，我看powersave那边也加锁了，那这边确实要加锁

deepin-ci-robot · 2023-10-23T03:30:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Decodetalkers

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Decodetalkers · 2023-10-23T03:30:42Z

那个锁在manager已经锁了一次了，所以如果再锁就会卡住

Decodetalkers · 2023-10-25T02:27:31Z

需要调研

deepin-bot · 2023-12-27T05:31:27Z

TAG Bot

New tag: 6.0.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #596

deepin-bot · 2024-01-05T07:53:52Z

TAG Bot

New tag: 6.0.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #604

Log:

deepin-bot · 2024-01-17T02:39:13Z

TAG Bot

New tag: 6.0.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #609

deepin-bot · 2024-01-26T08:31:48Z

TAG Bot

New tag: 6.0.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #613

deepin-bot · 2024-01-26T10:19:05Z

TAG Bot

New tag: 6.0.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #614

deepin-bot · 2024-02-06T02:11:54Z

TAG Bot

New tag: 6.0.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #616

Decodetalkers force-pushed the switchtotlp branch 3 times, most recently from 7469f0a to 414b5e4 Compare September 25, 2023 03:49

Decodetalkers requested a review from dengbo11 September 25, 2023 05:14

Decodetalkers closed this Sep 25, 2023

Decodetalkers reopened this Sep 25, 2023

Decodetalkers force-pushed the switchtotlp branch from 414b5e4 to cd04867 Compare September 25, 2023 05:46

dengbo11 requested changes Sep 28, 2023

View reviewed changes

Decodetalkers force-pushed the switchtotlp branch 2 times, most recently from 6ee7982 to 7a259f6 Compare September 28, 2023 05:04

dengbo11 previously approved these changes Oct 7, 2023

View reviewed changes

Decodetalkers force-pushed the switchtotlp branch from 7a259f6 to 559a4d7 Compare October 23, 2023 02:35

Decodetalkers dismissed dengbo11’s stale review via d481b14 October 23, 2023 03:30

Decodetalkers force-pushed the switchtotlp branch from 559a4d7 to d481b14 Compare October 23, 2023 03:30

Decodetalkers force-pushed the switchtotlp branch from d481b14 to 846e5be Compare October 23, 2023 08:32

Decodetalkers marked this pull request as draft October 25, 2023 02:27

feat(power)!: switch backend from lmt to tlp

adf72b6

Log:

Decodetalkers force-pushed the switchtotlp branch from 846e5be to adf72b6 Compare January 5, 2024 07:54

Decodetalkers closed this Feb 20, 2024

Conversation

Decodetalkers commented Sep 25, 2023

Uh oh!

Decodetalkers commented Sep 26, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepin-ci-robot commented Oct 23, 2023

Uh oh!

Decodetalkers commented Oct 23, 2023

Uh oh!

Decodetalkers commented Oct 25, 2023

Uh oh!

deepin-bot bot commented Dec 27, 2023

Uh oh!

deepin-bot bot commented Jan 5, 2024

Uh oh!

deepin-bot bot commented Jan 17, 2024

Uh oh!

deepin-bot bot commented Jan 26, 2024

Uh oh!

deepin-bot bot commented Jan 26, 2024

Uh oh!

deepin-bot bot commented Feb 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants