fix: Fix incompatible function pointer types with g_timeout_add_full on GCC 15#812
fix: Fix incompatible function pointer types with g_timeout_add_full on GCC 15#812mhduiy merged 1 commit intolinuxdeepin:masterfrom
Conversation
…on GCC 15 GCC 15 enforces stricter type checking for function pointers, which caused compilation errors when passing `handle_tap` and `handle_tap_destroy` to `g_timeout_add_full`. These functions were declared without parameters, but must match the expected signatures: - GSourceFunc: gboolean (*)(gpointer) - GDestroyNotify: void (*)(gpointer) Log: This patch updates the function signatures to ensure compatibility without changing their runtime behavior, as the `gpointer` parameter is unused in both functions.
|
Hi @hillwoodroc. Thanks for your PR. 😃 |
Reviewer's GuideThe patch updates two callback function signatures to include the required gpointer parameter, aligning them with GSourceFunc and GDestroyNotify for g_timeout_add_full without changing their runtime behavior. Class diagram for updated callback function signaturesclassDiagram
class core {
+gboolean handle_tap(gpointer data)
+void handle_tap_destroy(gpointer data)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @hillwoodroc. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @hillwoodroc - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot New tag: 6.1.38 |
|
TAG Bot New tag: 6.1.39 |
|
TAG Bot New tag: 6.1.40 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hillwoodroc, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
GCC 15 enforces stricter type checking for function pointers, which caused compilation errors when passing
handle_tapandhandle_tap_destroytog_timeout_add_full. These functions were declared without parameters, but must match the expected signatures:Log: This patch updates the function signatures to ensure compatibility without changing their runtime behavior, as the
gpointerparameter is unused in both functions.Summary by Sourcery
Bug Fixes: