Skip to content

chore: prohibit the startup and auto start of some services#820

Merged
mhduiy merged 1 commit intomasterfrom
autostart
Jun 30, 2025
Merged

chore: prohibit the startup and auto start of some services#820
mhduiy merged 1 commit intomasterfrom
autostart

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jun 26, 2025

  • The deepin-api-device, deepin-locale-helper, deepin-sound-theme-player can be started as needed.
  • Not suitable for upgrading scenarios

Log: prohibit the startup and auto start of some services

Summary by Sourcery

Prevent specified Deepin services from starting automatically or on installation

Chores:

  • Block auto-start and immediate startup of deepin-api-device during package actions
  • Block auto-start and immediate startup of deepin-locale-helper during package actions
  • Block auto-start and immediate startup of deepin-sound-theme-player during package actions

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 26, 2025

Reviewer's Guide

Updates the Debian packaging rules to disable the automatic startup of three Deepin services (deepin-api-device, deepin-locale-helper, deepin-sound-theme-player) by injecting dh_installsystemd overrides and clarifies that this change is not suitable for upgrade scenarios.

File-Level Changes

Change Details Files
Disable auto-start of selected services during package installation
  • Added override for dh_installsystemd to disable the three service units
  • Removed/enabled symlink creation for multi-user.target.wants to prevent automatic enabling
  • Refactored debian/rules to include custom disable targets
debian/rules
Clarify upgrade constraints
  • Inserted a log/comment noting that the disablement is not suitable for upgrade scenarios
debian/rules

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mhduiy mhduiy force-pushed the autostart branch 2 times, most recently from 3810cad to d6a1b20 Compare June 26, 2025 12:42
- The deepin-api-device, deepin-locale-helper, deepin-sound-theme-player can be started as needed.
- Not suitable for upgrading scenarios

Log: prohibit the startup and auto start of some services
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • override_dh_installsystemd函数中,添加了多个服务单元的安装配置,但未提供这些服务的详细说明或上下文。
  • 使用了--no-start选项,这意味着服务在安装后不会自动启动,这可能不符合预期的启动行为。

是否建议立即修改:

建议的修改措施:

  • 为每个服务单元添加注释,说明其用途和启动条件,以便其他开发者或维护者能够理解这些服务的安装和启动策略。
  • 如果这些服务确实不需要开机自启动,应该明确说明为什么选择--no-enable--no-start选项,而不是使用默认的启动策略。
  • 考虑是否有必要为每个服务单元单独配置启动选项,或者是否可以通过更通用的配置来管理这些服务。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2025

TAG Bot

New tag: 6.1.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #822

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 50862d0 into master Jun 30, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants