Skip to content

Revert "chore: prohibit the startup and auto start of some services"#826

Merged
mhduiy merged 1 commit intomasterfrom
autostart
Jul 3, 2025
Merged

Revert "chore: prohibit the startup and auto start of some services"#826
mhduiy merged 1 commit intomasterfrom
autostart

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jul 3, 2025

This reverts commit d6a1b20. This commit will cause the dbus service to fail to start

Summary by Sourcery

Bug Fixes:

  • Fix dbus service startup by restoring original service auto-start behavior

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 3, 2025

Reviewer's Guide

This PR reverts the earlier commit that disabled service startup in debian/rules, restoring the default behavior so that dbus (and other services) can start normally.

File-Level Changes

Change Details Files
Revert service startup prohibitions in packaging rules
  • Removed the override that passed ‘--no-start’ to dh_installinit/ dh_installsystemd
  • Deleted lines disabling auto-start of dbus and other services
  • Restored original dh_installinit and dh_installsystemd calls without startup flags
debian/rules

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 3, 2025

TAG Bot

New tag: 6.1.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #828

This reverts commit d6a1b20.
This commit will cause the dbus service to fail to start
@mhduiy mhduiy merged commit 9965a80 into master Jul 3, 2025
19 of 23 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 代码简化

    • override_dh_installsystemd函数中,原先有多个dh_installsystemd命令,每个命令都带有不同的参数。简化后的代码只保留了--no-start参数,这表明所有服务都不需要开机自启动。如果这是预期的行为,那么简化是合理的。如果某些服务需要开机自启动,那么应该明确列出这些服务。
  2. 注释清晰度

    • 原始代码中的注释使用了中文,这有助于理解代码的功能。简化后的代码没有注释,可能会降低代码的可读性。建议在简化代码的同时,保留或添加适当的注释,以解释为什么所有服务都不需要开机自启动。
  3. 功能一致性

    • 确保简化后的代码与原始代码在功能上是一致的。如果某些服务确实需要开机自启动,那么简化后的代码可能不正确。
  4. 代码维护性

    • 如果未来需要添加新的服务,简化后的代码可能需要更多的维护工作,因为需要手动添加新的dh_installsystemd命令。考虑使用脚本来自动化这个过程,以提高代码的可维护性。

综上所述,简化后的代码在功能上与原始代码一致,但可能需要添加注释以提高代码的可读性,并考虑使用脚本自动化服务添加过程以提高代码的维护性。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants