Merged
Conversation
单声道设置，原来的方案不通用，现在改为使用加载模块module-remap-sink的方式支持单声道模式。切换单声道模式时，改变sink-input和sink的绑定来处理没有声音的问题。 Log: 单声道模式方案变更，更加通用 PMS: TASK-369021 Influence: audio mono
Reviewer's GuideRefactors audio routing to support mono mode by leveraging the module-remap-sink plugin and centralizing sink-input movement logic, with added shell-script integration for toggling mono and extended virtual‐sink handling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @fly602, you have reached your weekly rate limit for Sourcery. Please try again later
Contributor
|
TAG Bot New tag: 6.1.53 |
deepin pr auto review代码审查报告1. 语法逻辑优点：
改进建议：
2. 代码质量优点：
改进建议：
3. 代码性能优点：
改进建议：
4. 代码安全优点：
改进建议：
5. 具体改进建议
func (a *Audio) moveSinkInputsToSink(inputs []uint32) {
if inputs == nil {
inputs = make([]uint32, 0)
// ... 其他逻辑
}
// ... 其余代码
}
func (a *Audio) executeCommand safely(command string, args ...string) error {
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
cmd := exec.CommandContext(ctx, command, args...)
if _, err := cmd.CombinedOutput(); err != nil {
return fmt.Errorf("command execution failed: %v", err)
}
return nil
}
const (
EchoCancelKey = "echo-cancel"
EchoCancelKey2 = "Echo-Cancel"
EchoCancelSource = "echoCancelSource"
RemapSinkMono = "remap-sink-mono"
)
func (a *Audio) getMasterNameFromVirtualDevice(device string) string {
if cached, ok := a.masterCache.Load(device); ok {
return cached.(string)
}
// ... 原有逻辑
a.masterCache.Store(device, master)
return master
}这些改进建议旨在提高代码的健壮性、可维护性和性能。建议根据实际需求逐步实施这些改进。 |
Contributor
|
/approvel |
mhduiy
approved these changes
Sep 10, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
单声道设置，原来的方案不通用，现在改为使用加载模块module-remap-sink的方式支持单声道模式。切换单声道模式时，改变sink-input和sink的绑定来处理没有声音的问题。
Log: 单声道模式方案变更，更加通用
PMS: TASK-369021
Influence: audio mono
Summary by Sourcery
Implement mono audio mode support using PulseAudio’s module-remap-sink, refactor sink input routing for both virtual and physical devices, and add a helper script to manage mono module loading.
New Features:
Enhancements: