Skip to content

fix: missing blur for Menu when it's parent is clip#282

Merged
BLumia merged 3 commits intolinuxdeepin:masterfrom
18202781743:fix-ui
May 15, 2024
Merged

fix: missing blur for Menu when it's parent is clip#282
BLumia merged 3 commits intolinuxdeepin:masterfrom
18202781743:fix-ui

Conversation

@18202781743
Copy link
Contributor

We use window instead of Item as Menu's parent.

TODO: it's a bug for dtk.

Issue: linuxdeepin/developer-center#8468

@18202781743
Copy link
Contributor Author

/integrate

@github-actions
Copy link

github-actions bot commented May 14, 2024

TAG Bot

TAG: 0.6.12
EXISTED: no
DISTRIBUTION: unstable

@github-actions
Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1432
PrNumber: 1432
PrBranch: auto-integration-9077817744

@18202781743
Copy link
Contributor Author

/integrate

Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 看漏了

@BLumia
Copy link
Member

BLumia commented May 14, 2024

/integrate

We use window instead of Item as Menu's parent.

TODO: it's a bug for dtk.

Issue: linuxdeepin/developer-center#8468
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FolderGridViewPopup.qml中,clip属性从true修改为根据gridViews.count的值来决定是否裁剪子视图。这个改动可能是为了确保仅在有多于一个子视图时才应用裁剪。
  • showContextMenu函数中增加了对objobj.Window.window的空值检查,并打印了一条日志。这可能是为了防止在尝试访问obj.Window.window.contentItem时发生错误。
  • showContextMenu函数被修改以首先调用closeContextMenu,这可能是为了在显示新菜单之前关闭现有的菜单。

是否建议立即修改:

  • 是,建议立即修改以确保代码的健壮性和可维护性。特别是对于空值检查和错误处理,这些改动有助于提高代码的健壮性。
  • 对于clip属性的改动,需要确保这个改动是基于实际的业务逻辑需求。如果业务逻辑确实需要始终裁剪子视图,那么这个改动可能不需要。如果不是,那么这个改动是合理的,应该立即采纳。

@18202781743
Copy link
Contributor Author

/integrate

@tsic404 tsic404 requested a review from BLumia May 14, 2024 12:55
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit d8c7b1f into linuxdeepin:master May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants