Skip to content

fix: modify the margins#288

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
zsien:zs/fix/margins
Jun 11, 2024
Merged

fix: modify the margins#288
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
zsien:zs/fix/margins

Conversation

@zsien
Copy link
Contributor

@zsien zsien commented May 24, 2024

当前外边距与设计不符

Issues: linuxdeepin/developer-center#8694

@zsien zsien requested a review from a team May 24, 2024 08:13
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

奇怪,这些边距间距都是之前设计走查调的,又改了么。。。。

@BLumia BLumia requested a review from a team May 24, 2024 09:46
@zsien
Copy link
Contributor Author

zsien commented May 29, 2024

奇怪,这些边距间距都是之前设计走查调的,又改了么。。。。

应该是的,这是上周设计提的单子

@zsien zsien force-pushed the zs/fix/margins branch from d42cdad to 4dabcea Compare May 30, 2024 02:49
@deepin-bot
Copy link

deepin-bot bot commented May 30, 2024

TAG Bot

New tag: 0.7.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #297

@kegechen
Copy link
Contributor

kegechen commented Jun 5, 2024

奇怪,这些边距间距都是之前设计走查调的,又改了么。。。。

应该是的,这是上周设计提的单子

fix fix margins 什么标题

@zsien zsien force-pushed the zs/fix/margins branch from d75ef6b to b3ca868 Compare June 5, 2024 08:51
@zsien zsien changed the title fix: fix margins fix: modify the margins Jun 5, 2024
@zsien
Copy link
Contributor Author

zsien commented Jun 5, 2024

奇怪,这些边距间距都是之前设计走查调的,又改了么。。。。

应该是的,这是上周设计提的单子

fix fix margins 什么标题

1

@zsien zsien force-pushed the zs/fix/margins branch from b3ca868 to 462b49c Compare June 6, 2024 01:55
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, zsien

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

当前外边距与设计不符

Issues: linuxdeepin/developer-center#8694
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • BottomBar.qml中,leftPaddingrightPadding属性被移除,取而代之的是padding属性,这可能会影响布局的完整性。需要确认这一改动是否符合设计要求。
  • WindowedFrame.qml中,anchors.leftMarginanchors.topMargin的值被增加到了10,这可能会影响布局的完整性。需要确保这些更改不会导致其他组件的布局出现问题。
  • WindowedFrame.qml中,sideBaranchors.topMargin被设置为10,这可能会影响布局的完整性。需要确保这些更改不会导致其他组件的布局出现问题。

是否建议立即修改:

  • 是,需要确保布局的完整性,避免因为这些更改而导致的问题。如果这些更改是经过设计团队批准的,那么可以接受这些更改。如果这些更改没有经过充分的审查,建议暂时回退这些更改,并进一步审查布局以确保其完整性。

@zsien
Copy link
Contributor Author

zsien commented Jun 11, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jun 11, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 47c5dc3 into linuxdeepin:master Jun 11, 2024
@zsien zsien deleted the zs/fix/margins branch June 11, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants