fix: folder icons did not update with the theme#293
Merged
zsien merged 1 commit intolinuxdeepin:masterfrom Jun 4, 2024
Merged
Conversation
zsien
force-pushed
the
zs/fix/foldericon
branch
2 times, most recently
from
448f57c to
956d3e7
Compare
BLumia
reviewed
May 29, 2024
Member
BLumia
left a comment
BLumia
left a comment
There was a problem hiding this comment.
有办法通过其它方式通知 folder-icon 图标引擎更新图标吗？主要这个文件夹图标 可能 还会在别的地方复用，如果不走图标引擎获取的话就意味着以后调样式要调多个地方的样式。
Contributor
Author
url 加上主题名应该可以。但我觉得复用的话，复用 QML 也完全没问题。 |
|
TAG Bot New tag: 0.7.0 |
Member
|
cc @kegechen |
kegechen
force-pushed
the
zs/fix/foldericon
branch
from
956d3e7 to
6d0fdce
Compare
deepin pr auto review关键摘要:
是否建议立即修改: |
18202781743
approved these changes
Jun 4, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, zsien The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: linuxdeepin/developer-center#8689