Skip to content

fix: sidebar icon not same as dfm sidebar icon#300

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
kegechen:8376
Jun 3, 2024
Merged

fix: sidebar icon not same as dfm sidebar icon#300
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
kegechen:8376

Conversation

@kegechen
Copy link
Contributor

@kegechen kegechen commented May 30, 2024

sidebar icon name tweak

Issue: linuxdeepin/developer-center#8376

@kegechen kegechen requested a review from BLumia May 30, 2024 05:03
BLumia
BLumia reviewed May 30, 2024
View reviewed changes
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是要改从图标主题里获取图标吗？如果是的话，之前附带的这几个图标资源需要删掉吗？之前是从资源文件里拿的： https://github.com/linuxdeepin/dde-launchpad/blob/master/qml.qrc

@deepin-bot
Copy link

deepin-bot bot commented May 30, 2024

TAG Bot

New tag: 0.7.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #297

@kegechen
Copy link
Contributor Author

kegechen commented May 31, 2024

这里是要改从图标主题里获取图标吗？如果是的话，之前附带的这几个图标资源需要删掉吗？之前是从资源文件里拿的： https://github.com/linuxdeepin/dde-launchpad/blob/master/qml.qrc

删掉了

@kegechen kegechen requested a review from BLumia May 31, 2024 01:10
@kegechen
fix: sidebar icon not same as dfm sidebar icon
9bc9108 
sidebar icon name tweak
remove builtin dci icons

Issue: linuxdeepin/developer-center#8376
@deepin-ci-robot
Copy link

deepin-ci-robot commented Jun 3, 2024

deepin pr auto review

关键摘要:

  • 删除的文件模式应为100755，而不是100644，因为这些文件是可执行的。
  • 在qml.qrc文件中，文件别名应使用小写字母，以保持与Qt资源文件命名规范一致。
  • 在SideBar.qml文件中，图标名称从"folder-images-symbolic"更改为"folder-pictures-symbolic"，需要确认这是否符合产品需求。
  • SideBar.qml文件中的KeyNavigation.up属性从"documents"更改为"computer"，需要验证这是否符合用户交互逻辑。

是否建议立即修改:
是

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
Copy link
Contributor Author

kegechen commented Jun 3, 2024

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jun 3, 2024

This pr cannot be merged! (status: blocked)

@kegechen
Copy link
Contributor Author

kegechen commented Jun 3, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jun 3, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 60c035a into linuxdeepin:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BLumia BLumia BLumia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kegechen @deepin-ci-robot @BLumia