Skip to content

fix: Fix resizable fullscreen frame in latest kwin PR#340

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
ArchieMeng:master
Jul 4, 2024
Merged

fix: Fix resizable fullscreen frame in latest kwin PR#340
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
ArchieMeng:master

Conversation

@ArchieMeng
Copy link
Contributor

Set fixed size for fullscreen frame

Issue: linuxdeepin/developer-center#9067
Log: Fix resizable fullscreen frame in latest kwin PR

@kegechen kegechen requested a review from BLumia July 1, 2024 08:15
@kegechen
Copy link
Contributor

kegechen commented Jul 1, 2024

/+1

Set fixed size for fullscreen frame

Issue: linuxdeepin/developer-center#9067
Log: Fix resizable fullscreen frame in latest kwin PR
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中,将最大宽度、高度和最小宽度、高度设置为相同的值,这可能意味着窗口的大小是固定的,这可能不是一个好的用户体验。
  • 注释使用了中文,但是代码中的变量和属性使用了英文,这种混合可能会导致混淆。

是否建议立即修改:

Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DWindow.enableSystemResize: false 不管用了吗? cc @kegechen

@BLumia BLumia requested a review from kegechen July 3, 2024 06:31
@kegechen
Copy link
Contributor

kegechen commented Jul 4, 2024

DWindow.enableSystemResize: false 不管用了吗? cc @kegechen

enableSystemResize 只是设置了 mouseInputAreaMargins 0, 只能禁止通过鼠标在窗口四周拖动大小,对于快捷键这些需要setfixsize

@kegechen kegechen requested a review from BLumia July 4, 2024 05:09
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng
Copy link
Contributor Author

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jul 4, 2024

This pr cannot be merged! (status: unstable)

@ArchieMeng
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 4, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 5112d8f into linuxdeepin:master Jul 4, 2024
@wineee wineee mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants