Skip to content

fix: when only one page, hide indicator.#564

Merged
BLumia merged 1 commit intolinuxdeepin:masterfrom
wjyrich:fix-bug-289095
May 21, 2025
Merged

fix: when only one page, hide indicator.#564
BLumia merged 1 commit intolinuxdeepin:masterfrom
wjyrich:fix-bug-289095

Conversation

@wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 15, 2025

as title.

PMS-BUG-289095

Summary by Sourcery

Bug Fixes:

  • Hide page indicator when only one page is present in FullscreenFrame.qml.

@github-actions
Copy link

github-actions bot commented May 15, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

anchors.horizontalCenter: parent.horizontalCenter
anchors.verticalCenter: parent.verticalCenter
visible: listviewPage.visible
visible: listviewPage.count !== 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Use the local count property in visibility binding

Bind visible to the local count instead of listviewPage.count so arrows hide correctly in search mode when count is 1.

Suggested change
visible: listviewPage.count !== 1
visible: count !== 1

@sourcery-ai
Copy link

sourcery-ai bot commented May 15, 2025

Reviewer's Guide

Updated the page indicator in FullscreenFrame.qml to hide when there is only a single page by switching its visibility check from listviewPage.visible to a count-based condition.

File-Level Changes

Change Details Files
Indicator visibility now depends on page count rather than visibility state
  • Modified the visible binding to use listviewPage.count !== 1
  • Removed old listviewPage.visible check
qml/FullscreenFrame.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-bot
Copy link

deepin-bot bot commented May 15, 2025

TAG Bot

New tag: 1.99.15
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #565

@wjyrich
Copy link
Contributor Author

wjyrich commented May 16, 2025

recheck

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 修改了 visible 属性的逻辑,可能影响 UI 的显示逻辑。

是否建议立即修改:

  • 是,需要确认修改后的逻辑是否符合预期,并确保不会引入新的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 51f33fd into linuxdeepin:master May 21, 2025
7 of 10 checks passed
@wjyrich wjyrich deleted the fix-bug-289095 branch June 6, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants