Skip to content

fix: Delete manually set IP address in IPv4 automatic mode#384

Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master
Aug 4, 2025
Merged

fix: Delete manually set IP address in IPv4 automatic mode#384
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23
Copy link
Contributor

@caixr23 caixr23 commented Jul 23, 2025

Delete manually set IP address in IPv4 automatic mode

pms: BUG-300227

Summary by Sourcery

Clear manual IP settings when switching to IPv4 automatic mode and refine address data validation.

Bug Fixes:

  • Remove leftover "addresses" and "address-data" entries from configuration in IPv4 auto mode.

Enhancements:

  • Wrap invalid addressData checks in braces for clearer flow control.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 23, 2025

Reviewer's Guide

Introduces deletion of manually configured IPv4 addresses when switching to automatic mode, and applies minor code style cleanups (bracing and whitespace) in SectionIPv4.qml.

Class diagram for SectionIPv4.qml changes

classDiagram
    class SectionIPv4 {
        +bool isEdit
        +string method
        +string errorKey
        +string errorMsg
        +editClicked()
        +getConfig()
    }
    SectionIPv4 : getConfig() updated to delete sConfig["addresses"] and sConfig["address-data"] when method is "auto"
Loading

File-Level Changes

Change Details Files
Ensure manual IP settings are removed in IPv4 automatic mode
  • Added else branch to delete sConfig["addresses"]
  • Added deletion of sConfig["address-data"]
dcc-network/qml/SectionIPv4.qml
Minor formatting cleanups
  • Converted single-line if-continue to braced block
  • Removed trailing whitespace from errorKey declaration
dcc-network/qml/SectionIPv4.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 31, 2025

TAG Bot

New tag: 2.0.64
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #387

Delete manually set IP address in IPv4 automatic mode

pms: BUG-300227
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码格式化:在修改的代码中,property string errorKey: "" 后面多余的空格应该删除。
  • 逻辑判断:在新增的 else 分支中,delete sConfig["addresses"]delete sConfig["address-data"] 可能会导致未定义的行为,因为 sConfig 可能是一个不可变的对象或数据结构。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit ab77697 into linuxdeepin:master Aug 4, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants