refactor: replace manual object management with DccRepeater#437
Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom Dec 9, 2025
Merged
refactor: replace manual object management with DccRepeater#437caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's GuideReplaces manual JavaScript-based object creation and cleanup with QML’s DccRepeater and DelegateChooser in networkMain.qml and PageDetails.qml, removing custom tracking arrays and update functions to simplify dynamic content management and improve maintainability. Class diagram for refactored dynamic object management in networkMain.qmlclassDiagram
class DccObject {
+showPage(cmd)
}
class DccRepeater {
+model
+delegate
}
class DelegateChooser {
+role
+DelegateChoice[]
}
class DelegateChoice {
+roleValue
+delegate
}
class PageWiredDevice {
+showPage
+item
}
class PageWirelessDevice {
+showPage
+item
}
class PageVPN {
+showPage
+item
+name
+parentName
+weight
}
class PageDSL {
+showPage
+item
+name
+parentName
+weight
}
class PageHotspot {
+showPage
+name
+parentName
+isAirplane
+weight
}
class PageSystemProxy {
+showPage
+name
+parentName
+weight
}
class PageDetails {
+showPage
+item
+name
+parentName
+weight
}
DccObject --> DccRepeater
DccRepeater --> DelegateChooser
DelegateChooser --> DelegateChoice
DelegateChoice --> PageWiredDevice
DelegateChoice --> PageWirelessDevice
DelegateChoice --> PageVPN
DelegateChoice --> PageDSL
DelegateChoice --> PageHotspot
DelegateChoice --> PageSystemProxy
DelegateChoice --> PageDetails
Class diagram for refactored details item management in PageDetails.qmlclassDiagram
class DccObject {
+infoItem
+name
+parentName
+description
+icon
+page
}
class DccRepeater {
+model
+delegate
}
DccObject --> DccRepeater
DccRepeater --> DccObject : delegate
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `dcc-network/qml/networkMain.qml:96` </location>
<code_context>
+ parentName: "network"
+ isAirplane: dccData.root.isEnabled
+ weight: 3030
+ Component.onCompleted: setItem(modelData)
+ }
+ }
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Using Component.onCompleted for setItem may cause timing issues.
This approach may not update the delegate if the model changes or the delegate is recreated. Consider using property binding or direct assignment to ensure the delegate stays in sync with model changes.
Suggested implementation:
```
weight: 3030
onModelDataChanged: setItem(modelData)
```
```
```
If `modelData` is not a property of the delegate, you may need to expose it or ensure that the delegate has access to it. Also, make sure that the delegate supports the `onModelDataChanged` signal handler. If not, you may need to use a property binding or a custom signal.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
TAG Bot New tag: 2.0.75 |
1. Replaced Component-based manual object creation/destruction with DccRepeater for dynamic content 2. Simplified PageDetails.qml by removing updateDetailsItems function and connections 3. Restructured networkMain.qml to use DelegateChooser with role-based delegation 4. Removed complex manual device tracking arrays (wiredDevs, wirelessDevs) 5. Eliminated updateDevice function and its associated cleanup logic 6. Added Qt.labs.qmlmodels import for DelegateChooser support The changes simplify dynamic object management by leveraging QML's built-in repeater components instead of manual JavaScript object lifecycle management. This reduces code complexity and potential memory leaks while improving maintainability. Influence: 1. Test network device list display with various device types 2. Verify dynamic addition/removal of network devices 3. Check that all device types (wired, wireless, VPN, DSL, hotspot, proxy) render correctly 4. Test airplane mode toggle and its effect on hotspot availability 5. Verify network details page shows proper information for different connections 6. Ensure proper weight ordering of network settings items refactor: 使用 DccRepeater 替换手动对象管理 1. 使用 DccRepeater 替换基于 Component 的手动对象创建/销毁逻辑 2. 简化 PageDetails.qml，移除 updateDetailsItems 函数和相关连接 3. 重构 networkMain.qml 使用基于角色的 DelegateChooser 委托机制 4. 移除复杂的手动设备跟踪数组（wiredDevs、wirelessDevs） 5. 消除 updateDevice 函数及其相关的清理逻辑 6. 添加 Qt.labs.qmlmodels 导入以支持 DelegateChooser 这些更改通过利用 QML 内置的重复器组件简化了动态对象管理，替代了手动 JavaScript 对象生命周期管理。这降低了代码复杂性和潜在的内存泄漏风险，同 时提高了可维护性。 Influence: 1. 测试各种设备类型的网络设备列表显示 2. 验证网络设备的动态添加/移除功能 3. 检查所有设备类型（有线、无线、VPN、DSL、热点、代理）是否正确渲染 4. 测试飞行模式切换及其对热点可用性的影响 5. 验证网络详情页面显示不同连接的正确信息 6. 确保网络设置项的正确权重排序
deepin pr auto review我来对这个 Git diff 进行代码审查：
总的来说，这次重构提升了代码质量，使代码更加现代化和可维护。但建议进行充分的测试，确保所有功能都能正常工作。 |
mhduiy
approved these changes
Dec 9, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes simplify dynamic object management by leveraging QML's built-in repeater components instead of manual JavaScript object lifecycle management. This reduces code complexity and potential memory leaks while improving maintainability.
Influence:
refactor: 使用 DccRepeater 替换手动对象管理
这些更改通过利用 QML 内置的重复器组件简化了动态对象管理，替代了手动
JavaScript 对象生命周期管理。这降低了代码复杂性和潜在的内存泄漏风险，同
时提高了可维护性。
Influence:
Summary by Sourcery
Refactor dynamic object management in networkMain.qml and PageDetails.qml to use QML’s built-in repeater components and delegate chooser, simplifying code and reducing potential memory leaks.
Enhancements: