chore: notify settings and icon tweak#367
Merged
kegechen merged 3 commits intolinuxdeepin:masterfrom May 24, 2024
Merged
Conversation
kegechen
force-pushed
the
qq_QQ
branch
2 times, most recently
from
c99fab2 to
07720b7
Compare
- get appid from AM first(pid ==> appid) - get appid from cached item info(.names) - if icon is empty get icon from settings linux.qq.com desktop 文件名是 qq.desktop 即 appID 是 qq ， 但是通知时 AppName 是QQ Issue: linuxdeepin/developer-center#8281
Contributor
Author
|
/integrate |
|
TAG Bot TAG: 6.0.19 |
|
AutoIntegrationPr Bot |
- GenericName[lang] first then Name[lang] - always update icon and name in initAllSettings Issue: linuxdeepin/developer-center#6907
release 6.0.19 Log: bump version to 6.0.19
Contributor
Author
|
/integrate |
deepin pr auto review关键摘要:
是否建议立即修改: 代码审查建议立即修改的原因是，新增的代码没有充分的上下文和初始化，可能会导致运行时错误或者数据不一致。特别是 |
18202781743
approved these changes
May 23, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, kegechen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: notify settings and icon tweak
linux.qq.com desktop 名是 qq.desktop 即 appID 是 qq ， 但是通知时 AppName 是QQ
Issue: linuxdeepin/developer-center#8281
Issue: linuxdeepin/developer-center#6907
b4:
now:
