chore: remove startdde dependency#392
Conversation
remove startdde dependency Log: remove startdde dependency pms: TASK-374777
Reviewer's Guide by SourceryThis pull request removes the Updated class diagram for Window classclassDiagram
class Window {
-m_gravityRotateBlackEnabled : bool
+Window(QWidget *parent)
}
note for Window "DConfig namespace updated from org.deepin.startdde to org.deepin.dde.daemon"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
总体来说,代码的更改看起来是合理的,但是需要确保所有的更改都已经过充分测试,并且与项目的其他部分保持一致。 |
There was a problem hiding this comment.
Hey @fly602 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's good to see the configuration namespace being updated to reflect the move away from startdde.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot TAG: 6.0.27 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
remove startdde dependency
Log: remove startdde dependency
pms: TASK-374777
Summary by Sourcery
Chores: