Skip to content

fix: Update dependencies for libimageeditor in debian/control and adj…#368

Merged
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master
Apr 16, 2025
Merged

fix: Update dependencies for libimageeditor in debian/control and adj…#368
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Apr 16, 2025

…ust CMakeLists.txt for versioning

  • Changed the dependency from libimageeditor-dev to libimageeditor6-dev in debian/control.
  • Updated CMakeLists.txt to append version suffix to the imagevisualresult library path and link accordingly.

Summary by Sourcery

Update library dependencies and CMake configuration to support Qt6 and libimageeditor6

Bug Fixes:

  • Modify library linking to correctly support Qt6 version of libimageeditor

Enhancements:

  • Add version suffix handling for imagevisualresult library to support multiple Qt versions

Build:

  • Update CMakeLists.txt to dynamically handle library paths and linking based on Qt version

…ust CMakeLists.txt for versioning

- Changed the dependency from libimageeditor-dev to libimageeditor6-dev in debian/control.
- Updated CMakeLists.txt to append version suffix to the imagevisualresult library path and link accordingly.
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 16, 2025

Reviewer's Guide by Sourcery

This pull request updates the dependencies in the debian/control file and adjusts the CMakeLists.txt file for versioning. Specifically, it changes the dependency from libimageeditor-dev to libimageeditor6-dev and updates the CMakeLists.txt to append a version suffix to the imagevisualresult library path and link accordingly.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the dependency for libimageeditor in the debian/control file.
  • Changed the dependency from libimageeditor-dev to libimageeditor6-dev.
debian/control
Adjusted CMakeLists.txt to handle versioning of the imagevisualresult library.
  • Added a suffix for the imagevisualresult library based on the Qt version.
  • Updated the library path to include the version suffix.
  • Updated the target link libraries to include the version suffix.
src/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dengzhongyuan365-dev - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more descriptive variable name than IMAGEVISUALRESULT_SUFFIX to improve readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Bump version to 6.5.17

Log: Bump version to 6.5.17
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 版本号更新

    • arm64/linglong.yamldebian/changeloglinglong.yamlloong64/linglong.yaml文件中,版本号从6.5.16.1更新到6.5.17.1。确认是否有相应的功能更新或修复,以及是否在提交信息中说明了版本更新的原因。
  2. 依赖库更新

    • debian/control文件中,libimageeditor被更新为libimageeditor6。确认是否有相应的库版本更新,以及是否所有相关的代码都已经适配了新的库版本。
  3. CMakeLists.txt文件

    • src/CMakeLists.txt文件中,添加了IMAGEVISUALRESULT_SUFFIX变量,并在设置LUT_DIR和链接库时使用了这个变量。这是一个好的做法,可以避免硬编码路径和库依赖。
    • 确认IMAGEVISUALRESULT_SUFFIX的值是否正确,以及是否所有相关的路径和库都使用了这个变量。
  4. 代码注释和文档

    • 检查是否有必要更新或添加代码注释,特别是对于新添加的变量和逻辑。
    • 确保提交信息清晰明了,说明版本更新的原因和所做的更改。
  5. 测试

    • 确保在更新版本和依赖库后,进行了充分的测试,包括单元测试和集成测试,以确保更改没有引入新的问题。
  6. 代码风格

    • 检查代码风格是否一致,特别是缩进和空格的使用。
    • 确保代码中没有多余的空行或注释,保持代码的整洁。
  7. 安全性

    • 确认是否有必要更新或添加安全相关的代码,例如更新依赖库以修复已知的安全漏洞。
  8. 性能

    • 确认是否有必要优化代码性能,特别是对于新添加的变量和逻辑。

总体来说,这次提交主要是版本更新和依赖库的调整,没有明显的语法或逻辑错误。但是,需要确保所有更改都已经经过充分的测试,并且提交信息清晰明了。

@github-actions
Copy link

TAG Bot

TAG: 6.5.17
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dengzhongyuan365-dev
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 16, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 49bc8e5 into linuxdeepin:master Apr 16, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants