fix: Update dependencies for libimageeditor in debian/control and adj…#368
fix: Update dependencies for libimageeditor in debian/control and adj…#368deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom dengzhongyuan365-dev:master
Conversation
…ust CMakeLists.txt for versioning - Changed the dependency from libimageeditor-dev to libimageeditor6-dev in debian/control. - Updated CMakeLists.txt to append version suffix to the imagevisualresult library path and link accordingly.
Reviewer's Guide by SourceryThis pull request updates the dependencies in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @dengzhongyuan365-dev - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more descriptive variable name than
IMAGEVISUALRESULT_SUFFIXto improve readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Bump version to 6.5.17 Log: Bump version to 6.5.17
deepin pr auto review代码审查意见:
总体来说,这次提交主要是版本更新和依赖库的调整,没有明显的语法或逻辑错误。但是,需要确保所有更改都已经经过充分的测试,并且提交信息清晰明了。 |
|
TAG Bot TAG: 6.5.17 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
…ust CMakeLists.txt for versioning
Summary by Sourcery
Update library dependencies and CMake configuration to support Qt6 and libimageeditor6
Bug Fixes:
Enhancements:
Build: