Skip to content

fix: Fix linglong build fail#370

Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr-0417
Apr 17, 2025
Merged

fix: Fix linglong build fail#370
lzwind merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr-0417

Conversation

@wangrong1069
Copy link
Contributor

@wangrong1069 wangrong1069 commented Apr 17, 2025

As title.

Log: Fix linglong build fail

Summary by Sourcery

Fix linglong build configuration for deepin-camera

New Features:

  • Update package version to 6.5.19.1

Enhancements:

  • Modify service file path search to only look in 'src' directory
  • Update dependencies to newer library versions

As title.

Log: Fix linglong build fail
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This pull request updates the linglong.yaml files for arm64, amd64, and loong64 architectures to fix a build failure. It updates the package version, modifies the search path for service files during the build process, and updates the list of debian packages to install along with their URLs and digests.

Updated class diagram for linglong.yaml

classDiagram
    class linglong.yaml {
        -id: string
        -name: string
        -version: string
        -kind: string
        -description: string
        -build: string
        -sources: list
    }
    note for linglong.yaml "This diagram shows the structure of the linglong.yaml file."
Loading

File-Level Changes

Change Details Files
Update package version and modify the path for service files in the build process.
  • Update the package version from 6.5.18.1 to 6.5.19.1.
  • Modify the find command in the build script to search for service files in the src directory instead of the entire project directory.
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml
Update the list of debian packages to install and their corresponding URLs and digests.
  • Update the list of debian packages to install by adding libimageeditor6-dev, libimageeditor6, and libimageeditor.
  • Update the URLs and digests of various debian packages to point to newer versions.
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

TAG Bot

TAG: 6.5.19
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wangrong1069 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like you're updating the package versions and dependencies, so double-check that the application still functions as expected with these changes.
  • Consider using a script to generate the sources list to avoid manual errors.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit d133270 into linuxdeepin:master Apr 17, 2025
16 of 18 checks passed
@wangrong1069 wangrong1069 deleted the pr-0417 branch April 17, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants