feat: enhance dbus security#121
Merged
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom Sep 11, 2024
Merged
Conversation
Contributor
wangrong1069
commented
Sep 10, 2024
- add polkit support.
- fix command injection.
The following methods will be used to determine the identity of the caller: 1. Determine whether it is a front-end process through dbus name. 2. Determine whether it is a root process through the caller uid. 3. Determine whether it is an administrator through polkit. Log: enhance security for deepin-diskmanager-service Task: https://pms.uniontech.com/task-view-355353.html
Convert all `bash -c "command"` command invocations to direct QProcess invocations. Log: enhance security for deepin-diskmanager-service Task: https://pms.uniontech.com/task-view-355353.html
deepin pr auto reviewFix the problem of not checking the authorization when starting the service |
|
TAG Bot TAG: 1.3.38 |
|
[是否满足兼容性要求] Y |
re2zero
approved these changes
Sep 11, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: re2zero, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
This was referenced Sep 11, 2024
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.