Skip to content

feat: enhance dbus security#121

Merged
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
wangrong1069:dbus-security
Sep 11, 2024
Merged

feat: enhance dbus security#121
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
wangrong1069:dbus-security

Conversation

@wangrong1069
Copy link
Contributor

  • add polkit support.
  • fix command injection.

The following methods will be used to determine the identity of the caller:
1. Determine whether it is a front-end process through dbus name.
2. Determine whether it is a root process through the caller uid.
3. Determine whether it is an administrator through polkit.

Log: enhance security for deepin-diskmanager-service
Task: https://pms.uniontech.com/task-view-355353.html
Convert all `bash -c "command"` command invocations to direct QProcess invocations.

Log: enhance security for deepin-diskmanager-service
Task: https://pms.uniontech.com/task-view-355353.html
@deepin-ci-robot
Copy link

deepin pr auto review

Fix the problem of not checking the authorization when starting the service

@github-actions
Copy link

TAG Bot

TAG: 1.3.38
EXISTED: no
DISTRIBUTION: unstable

@lzwind
Copy link

lzwind commented Sep 10, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: re2zero, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/forcemerge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants