Skip to content

chore: Update deepin-manual resources#145

Merged
lzwind merged 2 commits intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master
Jun 20, 2025
Merged

chore: Update deepin-manual resources#145
lzwind merged 2 commits intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Jun 20, 2025

chore: Update deepin-manual resources

  • Update deepin-manual resources

log: Update deepin-manual resources

Summary by Sourcery

Enable position-independent execution for binaries and refresh deepin-manual resources.

Enhancements:

  • Enable PIE for application and service binaries by adding -fPIE and -pie flags in CMake configurations

Documentation:

  • Remove obsolete stop.png screenshot reference from Chinese manual

Chores:

  • Update deepin-manual SVG assets and bump Debian changelog

- Update deepin-manual resources

log: Update deepin-manual resources
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dengzhongyuan365-dev - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 20, 2025

Reviewer's Guide

This PR enforces PIE build flags across both application and service builds, cleans up the Chinese manual by removing an obsolete icon reference, refreshes key SVG assets, and updates the Debian changelog entry.

Class diagram for CMake build configuration changes

classDiagram
    class ApplicationCMakeLists {
        +CMAKE_CXX_FLAGS : string
        +CMAKE_C_FLAGS : string
        +CMAKE_EXE_LINKER_FLAGS : string
        +APP_DESKTOP : string
        +APP_QRC : string
        +APP_ICONPATH : string
        +configure_file()
    }
    class ServiceCMakeLists {
        +CMAKE_CXX_FLAGS : string
        +CMAKE_C_FLAGS : string
        +CMAKE_EXE_LINKER_FLAGS : string
        +APP_USBREMOVE_FILES : string
        +APP_DEEPIN_DISKMANAGER_SERVICE_BIN : string
        +APP_POLICY_DIR : string
        +APP_POLICY_FILES : string
        +find_package()
    }
    ApplicationCMakeLists <|-- ServiceCMakeLists : "similar build flag changes"
    note for ApplicationCMakeLists "Added: -fPIE to CMAKE_CXX_FLAGS and CMAKE_C_FLAGS, -pie to CMAKE_EXE_LINKER_FLAGS"
    note for ServiceCMakeLists "Added: -fPIE to CMAKE_CXX_FLAGS and CMAKE_C_FLAGS, -pie to CMAKE_EXE_LINKER_FLAGS"
Loading

File-Level Changes

Change Details Files
Enforce PIE build flags across application and service
  • Add -fPIE to C and C++ compiler flags
  • Add -pie to the executable linker flags
application/CMakeLists.txt
service/CMakeLists.txt
Remove outdated stop icon reference in Chinese manual
  • Delete the embedded stop icon markdown
  • Remove extra blank lines
application/assets/deepin-diskmanager/disk-manager/zh_CN/disk-manager.md
Refresh SVG assets for disk manager and launcher
  • Replace launcher SVG
  • Update main disk manager SVG
  • Update 96px disk manager SVG
application/assets/deepin-diskmanager/disk-manager/common/deepin_launcher.svg
application/assets/deepin-diskmanager/disk-manager/common/disk_manager.svg
application/assets/deepin-diskmanager/disk-manager/common/disk_manager_96.svg
Update Debian package changelog
  • Refresh changelog entry metadata
  • Bump package version
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

TAG Bot

TAG: 6.0.4
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt文件中,添加了-fPIE-pie编译和链接选项,这有助于提高程序的安全性。建议确认这些选项是否适用于所有目标平台,并确保它们不会与现有的编译选项冲突。

  2. deepin-diskmanager.svgdisk_manager.svgdisk_manager_96.svg文件中,SVG图像的viewBox属性被修改,这可能会影响图像的显示比例。建议检查这些修改是否与设计意图一致,并确保所有在不同尺寸下都能正确显示。

  3. disk-manager.md文件中,删除了关于停止检测的图片注释,这可能会影响文档的可读性。建议保留这些注释,或者提供替代的说明。

  4. CMakeLists.txt文件中,添加了-fPIE-pie编译和链接选项,这有助于提高程序的安全性。建议确认这些选项是否适用于所有目标平台,并确保它们不会与现有的编译选项冲突。

  5. service/CMakeLists.txt文件中,添加了-fPIE-pie编译和链接选项,这有助于提高程序的安全性。建议确认这些选项是否适用于所有目标平台,并确保它们不会与现有的编译选项冲突。

  6. debian/changelog文件中,添加了一个新的变更日志条目,记录了更新deepin-manual资源的操作。建议确认这个变更是否正确,并确保它不会影响其他文档。

  7. service/CMakeLists.txt文件中,添加了-fPIE-pie编译和链接选项,这有助于提高程序的安全性。建议确认这些选项是否适用于所有目标平台,并确保它们不会与现有的编译选项冲突。

总体,这些更改都是为了提高程序的安全性和稳定性,以及确保文档的准确性和完整性。建议在合并这些更改之前,进行充分的测试和验证。

@lzwind lzwind merged commit 9da8df1 into linuxdeepin:master Jun 20, 2025
15 of 18 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants