Skip to content

feat: Update translations for Lao locale#164

Closed
JWWTSL wants to merge 0 commit intolinuxdeepin:masterfrom
JWWTSL:master
Closed

feat: Update translations for Lao locale#164
JWWTSL wants to merge 0 commit intolinuxdeepin:masterfrom
JWWTSL:master

Conversation

@JWWTSL
Copy link
Contributor

@JWWTSL JWWTSL commented Aug 7, 2025

log: Translation update

Summary by Sourcery

Add Lao locale support by introducing new translation files for the application, desktop entry and policy components.

New Features:

  • Add Lao locale translations for deepin-diskmanager UI texts
  • Provide Lao translations for desktop entry metadata
  • Include Lao language strings for authorization policy messages

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

TAG Bot

TAG: 6.0.12
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 7, 2025

Reviewer's Guide

This PR adds Lao locale support by introducing translation TS files for the main application UI, desktop entry and policy messages, and updates the Debian changelog to record the translation update.

File-Level Changes

Change Details Files
Add main application Lao translation file
  • New TS file containing over 2,300 Lao translations across multiple UI contexts
application/translations/deepin-diskmanager_lo.ts
Add Lao desktop entry translations
  • New desktop translation file with localized Name and GenericName entries
application/translations/desktop/desktop_lo.ts
Add policy message translations for Lao
  • New policy translation file covering authentication prompts
application/translations/policy/policy_lo.ts
Update Debian changelog
  • Insert translation update log entry
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JWWTSL - I've reviewed your changes - here's some feedback:

  • There are many entries still marked as unfinished or containing non-Lao text—please complete these translations with valid Lao strings before merging.
  • Several translations include other languages or gibberish; audit the file to ensure every element contains correct and consistent Lao phrasing.
  • Double-check placeholder usage (e.g., %1) and comment contexts (like button labels) in your Lao translations to make sure they match the source formatting.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are many entries still marked as unfinished or containing non-Lao text—please complete these translations with valid Lao strings before merging.
- Several translations include other languages or gibberish; audit the file to ensure every <translation> element contains correct and consistent Lao phrasing.
- Double-check placeholder usage (e.g., %1) and comment contexts (like button labels) in your Lao translations to make sure they match the source formatting.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查结果如下:

  1. 代码格式和风格:代码中存在一些格式问题,例如缩进不一致、空格使用不统一等。建议统一代码风格,以提高代码的可读性。

  2. 国际化:代码中存在一些硬编码的字符串,建议使用国际化资源文件(如.ts文件)来管理这些字符串,以便于后续的翻译和维护。

  3. 错误处理:代码中缺少对错误情况的处理,例如文件读写失败、网络请求失败等。建议增加错误处理逻辑,以便于在出现问题时能够给出明确的错误提示。

  4. 安全性:代码中存在一些潜在的安全风险,例如硬编码的敏感信息、不安全的文件操作等。建议对敏感信息进行加密处理,并对文件操作进行安全检查,以防止潜在的安全漏洞。

  5. 代码注释:代码中缺少必要的注释,特别是对于复杂的逻辑和关键步骤。建议增加注释,以便于其他开发者理解和维护代码。

  6. 代码重复:代码中存在一些重复的逻辑和代码片段。建议提取公共代码到独立的函数或类中,以减少代码重复,提高代码的可维护性。

  7. 代码性能:代码中存在一些性能瓶颈,例如在循环中进行了大量的计算或I/O操作。建议优化这些代码,以提高代码的性能。

  8. 代码健壮性:代码中存在一些潜在的健壮性问题,例如对空指针、边界条件等没有进行充分的检查和处理。建议增加对这些问题的检查和处理,以提高代码的健壮性。

以上是本次代码审查的主要发现,希望能够对您有所帮助。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 7, 2025

TAG Bot

New tag: 6.0.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #166

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants