Pr0902

[wangrong1069]

Summary by Sourcery

Disable installation of internal-use-only modules by removing their CMake install directives

Build:

• Remove CMake install directives for basestruct module
• Remove CMake install directives for log module

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes install directives in internal CMakeLists files to prevent accidental system installation and updates packaging metadata files.

File-Level Changes

Change	Details	Files
Removed install directives from CMakeLists	Deleted CMAKE_INSTALL_PREFIX setting Removed install(TARGETS … DESTINATION lib) Added comment indicating internal use only	basestruct/CMakeLists.txt log/CMakeLists.txt
Updated packaging metadata	Bumped or placeholder edit in debian/changelog Re-synced diskmanager-daemon.service file	debian/changelog service/assets/data/diskmanager-daemon.service

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

TAG Bot

TAG: 6.0.18
EXISTED: no
DISTRIBUTION: unstable

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来分析这个git diff，并提供改进意见：

1. basestruct/CMakeLists.txt 的修改

改动内容：

• 移除了 CMAKE_INSTALL_PREFIX /usr 的设置
• 注释掉了 install(TARGETS ${PROJECT_NAME} DESTINATION lib) 命令
• 添加了 # not install for internal use 的注释

改进建议：

1. 代码清晰度：虽然注释说明了不安装的原因，但最好在CMakeLists.txt文件开头添加更详细的注释，解释为什么这个模块是内部使用的。
2. 代码组织：建议将所有与安装相关的配置集中在一起，而不是散布在文件各处。
3. 维护性：如果这是一个长期决定，应该在项目的顶层CMakeLists.txt中也体现这个策略，避免在其他模块中重复设置。

2. debian/changelog 的修改

改动内容：

• 添加了一个新的版本条目 (6.0.18)
• 记录了移除不必要静态库安装的变更

改进建议：

1. 变更描述：changelog中的描述"Remove unnecessary static library installation"不够具体，应该更详细地说明移除了哪些库以及为什么移除。
2. 版本号：确保新版本号(6.0.18)符合项目的版本控制策略。
3. 时间戳：时间戳 Wed, 03 Sep 2025 10:39:09 +0800 看起来像是未来的日期，应该检查是否正确。

3. log/CMakeLists.txt 的修改

改动内容：

• 与basestruct/CMakeLists.txt相同的修改

改进建议：

1. 代码重复：这种相同的修改出现在多个模块中，建议在顶层CMakeLists.txt中统一处理安装策略，避免重复代码。
2. 文档：建议在项目的README或文档中说明哪些模块是内部使用的，以及如何正确构建和安装整个项目。

4. diskmanager-daemon.service 的修改

改动内容：

• 将 MemoryLimit=8G 改为 MemoryMax=8G

改进建议：

1. 兼容性：确保 MemoryMax 被所有目标系统支持。在某些旧版本的systemd中，可能只支持 MemoryLimit。
2. 文档：建议在变更日志中解释为什么从 MemoryLimit 改为 MemoryMax。
3. 测试：这种配置变更应该经过充分测试，确保服务在目标系统上正常运行。

总体建议

1. 一致性：确保所有模块的修改策略保持一致，避免部分模块安装而其他模块不安装的情况。
2. 文档更新：更新项目的构建和安装文档，明确说明哪些组件会被安装，哪些是内部使用的。
3. 测试：对于所有配置变更，特别是systemd服务的配置变更，应该进行充分的测试。
4. 变更管理：对于这类影响构建和安装流程的变更，应该通过代码审查流程确保所有相关人员了解变更内容。

这些修改看起来是为了优化项目的构建和安装流程，减少不必要的组件安装。建议在实施这些变更时，确保所有相关文档都得到更新，并且所有开发团队成员都了解这些变更的影响。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wangrong1069]

/forcemerge

[deepin-bot]

This pr force merged! (status: unstable)