Conversation
|
Hi @imguoguo. Thanks for your PR. 😃 |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Reviewer's Guide by SourceryThis pull request updates the C++ standard to C++17 in the CMakeLists.txt file. This change is necessary to ensure compatibility with ICU 75+. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @imguoguo. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Hey @imguoguo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment in the CMakeLists.txt file explaining why the C++ standard was bumped to 17.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/deepin-editor\"",
"line_number": 8,
"rule": "S35",
"reason": "Url link | 9c6a12da6f"
}
]
} |
|
I have read the CLA Document and I hereby sign the CLA. |
ICU 75+ requires C++17 to build.
|
Note
详情{
"CMakeLists.txt": [
{
"line": " HOMEPAGE_URL \"https://github.com/linuxdeepin/deepin-editor\"",
"line_number": 8,
"rule": "S35",
"reason": "Url link | 9c6a12da6f"
}
]
} |
|
TAG Bot New tag: 6.5.19 |
|
TAG Bot New tag: 6.5.20 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: imguoguo, rb-union The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ICU 75+ requires C++17 to build.
Fix: developer-center/issues#8840
Similar to: deepin-music/pull#462
Summary by Sourcery
Build: