Skip to content

fix: build with icu 75+#338

Merged
rb-union merged 1 commit intolinuxdeepin:masterfrom
imguoguo:master
Mar 31, 2025
Merged

fix: build with icu 75+#338
rb-union merged 1 commit intolinuxdeepin:masterfrom
imguoguo:master

Conversation

@imguoguo
Copy link
Contributor

@imguoguo imguoguo commented Mar 27, 2025

ICU 75+ requires C++17 to build.

Fix: developer-center/issues#8840
Similar to: deepin-music/pull#462

Summary by Sourcery

Build:

  • Modify CMakeLists.txt to change the C++ standard from C++11 to C++17 to support building with newer ICU versions

@deepin-ci-robot
Copy link

Hi @imguoguo. Thanks for your PR. 😃

@github-actions
Copy link

github-actions bot commented Mar 27, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 27, 2025

Reviewer's Guide by Sourcery

This pull request updates the C++ standard to C++17 in the CMakeLists.txt file. This change is necessary to ensure compatibility with ICU 75+.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the C++ standard to C++17 to ensure compatibility with ICU 75+.
  • Set the CMAKE_CXX_STANDARD variable to 17.
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

Hi @imguoguo. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imguoguo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment in the CMakeLists.txt file explaining why the C++ standard was bumped to 17.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "CMakeLists.txt": [
        {
            "line": "    HOMEPAGE_URL \"https://github.com/linuxdeepin/deepin-editor\"",
            "line_number": 8,
            "rule": "S35",
            "reason": "Url link | 9c6a12da6f"
        }
    ]
}

@imguoguo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

deepin-bot bot added a commit to linuxdeepin/cla that referenced this pull request Mar 27, 2025
ICU 75+ requires C++17 to build.
@github-actions
Copy link

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "CMakeLists.txt": [
        {
            "line": "    HOMEPAGE_URL \"https://github.com/linuxdeepin/deepin-editor\"",
            "line_number": 8,
            "rule": "S35",
            "reason": "Url link | 9c6a12da6f"
        }
    ]
}

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 28, 2025

TAG Bot

New tag: 6.5.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #339

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 28, 2025

TAG Bot

New tag: 6.5.20
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #341

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: imguoguo, rb-union

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit b815b60 into linuxdeepin:master Mar 31, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

These applications can not build on ICU 75

3 participants