Fix: Qt6 / Qt5 compatibility | Bump version to 6.5.23#347
Fix: Qt6 / Qt5 compatibility | Bump version to 6.5.23#347rb-union merged 2 commits intolinuxdeepin:masterfrom
Conversation
Change dde-qt5integration to dde-qt6integration | dde-qt5integration Change libdtkwidget5 to libdtk6widget | libdtkwidget5 Log: Update dependencies to support both Qt5 and Qt6
Bump version to 6.5.23 Log: Bump version to 6.5.23
|
Warning
|
deepin pr auto review代码审查意见:
综上所述,代码的版本更新和依赖项变更看起来是合理的,但需要确保这些变更与实际的功能实现相匹配,并且进行了充分的测试和文档说明。 |
Reviewer's Guide by SourceryThis pull request updates the application to support both Qt5 and Qt6 by modifying dependencies and bumps the version to 6.5.23. The dependencies Updated class diagram for dependenciesclassDiagram
class deepin-editor {
- dde-qt5integration
- libdtkwidget5
+ dde-qt6integration
+ libdtk6widget
}
note for deepin-editor "Updated dependencies to support both Qt5 and Qt6"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @rb-union - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a script to update the version across all files to avoid manual errors.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot TAG: 6.5.23 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, rb-union The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fix: Add Qt6 support while maintaining Qt5 compatibility
Change dde-qt5integration to dde-qt6integration | dde-qt5integration
Change libdtkwidget5 to libdtk6widget | libdtkwidget5
Log: Update dependencies to support both Qt5 and Qt6
chore: Bump version to 6.5.23
Bump version to 6.5.23
Log: Bump version to 6.5.23
Summary by Sourcery
Update project to support Qt6 while maintaining Qt5 compatibility and bump the application version
New Features:
Enhancements:
Chores: