Skip to content

chore: Bump version to 6.5.45#427

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr0305
Mar 5, 2026
Merged

chore: Bump version to 6.5.45#427
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr0305

Conversation

@wangrong1069
Copy link
Contributor

@wangrong1069 wangrong1069 commented Mar 5, 2026

As title.

Log: Bump version to 6.5.45

Summary by Sourcery

Bump application package version metadata to 6.5.45.1 in linglong configuration.

As title.

Log: Bump version to 6.5.45
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

TAG Bot

TAG: 6.5.45
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR performs a simple version bump of the deepin-editor package from 6.5.44.1 to 6.5.45.1 in the linglong configuration, aligning metadata with the new release version.

File-Level Changes

Change Details Files
Update package metadata to reflect the new 6.5.45.1 release version.
  • Bump the deepin-editor package version field from 6.5.44.1 to 6.5.45.1 in the linglong configuration file.
  • Ensure release metadata is prepared for the 6.5.45.1 build.
linglong.yaml
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这份 git diff 主要包含了软件包版本更新日志 (debian/changelog) 和打包配置文件 (linglong.yaml) 的变更。虽然这些文件不包含直接的逻辑代码,但它们对于软件发布、构建和版本管理至关重要。

以下是对本次变更的详细审查和改进意见:

1. 变更内容分析

  • debian/changelog:
    • 更新了版本号至 6.5.45
    • 添加了两条修复记录:
      1. 修复了 TextEdit 析构函数中未断开 D-Bus 信号的问题,防止悬空指针导致的崩溃(内存安全/稳定性修复)。
      2. 修复了 CMake 构建系统中找不到 lrelease 的问题,通过使用 Qt6 的 LinguistTools 目标(构建系统修复)。
  • linglong.yaml:
    • version 字段从 6.5.44.1 同步更新至 6.5.45.1

2. 审查意见

A. 语法与格式

  • 现状: 两个文件的格式均符合各自的规范。debian/changelog 遵循了标准的 Debian 格式,linglong.yaml 符合 YAML 语法。
  • 评价: 格式正确,缩进无误。

B. 代码质量与逻辑

  • 版本号一致性:
    • debian/changelog 中的版本是 6.5.45
    • linglong.yaml 中的版本是 6.5.45.1
    • 意见: 这里存在版本号不一致的情况。通常 linglong.yaml 的版本号会对应 debian/changelog 的上游版本号加上构建号(例如 .1)。如果这是预期的打包策略(即 .1 代表该源码版本的第一次打包),则是合理的。但需要确认 debian/changelog 中的版本号是否也应该包含构建号,或者 linglong.yaml 是否应该直接使用 6.5.45。建议统一版本管理策略。

C. 代码性能

  • 现状: 配置文件的变更不直接影响运行时性能。
  • 潜在影响:
    • fix(editor): Disconnect D-Bus signals... 这条变更虽然未在 diff 中展示代码,但从描述来看,它修复了析构后的回调问题。这属于内存安全范畴,虽然不直接提升计算性能,但避免了程序崩溃,保证了系统的长期稳定运行,间接提升了用户体验。

D. 代码安全

  • 现状: 配置文件本身无安全风险。
  • 潜在影响:
    • D-Bus 信号修复: Disconnect D-Bus signals in TextEdit destructor 是一个非常重要的安全修复。如果对象被销毁后 D-Bus 信号仍然尝试调用该对象的成员函数(回调),将导致**Use-After-Free(释放后使用)**漏洞,进而引发段错误或潜在的安全攻击。修复此问题显著提高了软件的安全性。

3. 改进建议

  1. 版本号规范化:

    • 建议检查 CI/CD 流程或打包脚本,确保 debian/changeloglinglong.yaml 的版本号能够自动同步或遵循明确的命名规则,避免手动修改时出现不一致。
    • 例如,如果 linglong.yaml6.5.45.1 是为了区分不同的构建迭代,建议在 debian/changelog 中也体现这一点,或者在文档中明确说明两者的对应关系。
  2. Changelog 描述优化:

    • fix(cmake): Fix lrelease not found by using Qt6 LinguistTools target 这条描述非常清晰。
    • fix(editor): Disconnect D-Bus signals... 描述也很准确。建议在提交信息或代码审查时,关联相关的 Issue ID 或 Bug ID,便于后续追踪。
  3. 日期检查:

    • debian/changelog 中的日期是 Thu, 05 Mar 2026。这看起来像是一个未来的日期。除非这是为了测试或特定的发布计划,否则通常应使用当前的实际日期。请确认这是否为笔误(例如应为 2024 或 2025)。

总结

本次变更主要针对构建系统和潜在的内存安全问题进行了修复,配置文件格式正确。主要的改进点在于确认版本号策略的一致性以及核对 changelog 中的日期准确性。从描述来看,核心的代码修复(D-Bus 断开连接)是非常必要的,有助于提升程序的稳定性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 5, 2026

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 2b0bcc8 into linuxdeepin:master Mar 5, 2026
21 of 23 checks passed
@wangrong1069 wangrong1069 deleted the pr0305 branch March 5, 2026 12:44
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 5, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.45
  • Tag SHA: 66dc86f8923b3d429c0fdb0494abe1f718a4a2d7
  • Commit SHA: d6de06c475c3e54ef454becda268afbf5280aa51
  • Tag Message:
    Release deepin-editor 6.5.45
    
    
  • Tagger:
    • Name: wangrong1069
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants