Skip to content

refactor: modify test build configuration#44

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Johnson-zs:master
Aug 5, 2025
Merged

refactor: modify test build configuration#44
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Johnson-zs:master

Conversation

@Johnson-zs
Copy link
Contributor

  1. Changed default BUILD_TESTS option from OFF to ON to encourage testing
  2. Added conditional check for Debug build type before including tests directory
  3. These changes ensure tests are only built during development (Debug mode)
  4. Improves development workflow while preventing test builds in production

refactor: 修改测试构建配置

  1. 将 BUILD_TESTS 选项默认值从 OFF 改为 ON 以鼓励测试
  2. 在包含测试目录前添加了对 Debug 构建类型的条件检查
  3. 这些更改确保测试仅在开发(Debug模式)期间构建
  4. 改善了开发工作流程同时避免在生产环境中构建测试

1. Changed default BUILD_TESTS option from OFF to ON to encourage
testing
2. Added conditional check for Debug build type before including tests
directory
3. These changes ensure tests are only built during development (Debug
mode)
4. Improves development workflow while preventing test builds in
production

refactor: 修改测试构建配置

1. 将 BUILD_TESTS 选项默认值从 OFF 改为 ON 以鼓励测试
2. 在包含测试目录前添加了对 Debug 构建类型的条件检查
3. 这些更改确保测试仅在开发(Debug模式)期间构建
4. 改善了开发工作流程同时避免在生产环境中构建测试
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • BUILD_TESTS 选项默认值从 OFF 改为 ON,可能会影响构建流程,需要确认这是否是预期的行为。
  • if(BUILD_TESTS) 块中添加了对 CMAKE_BUILD_TYPE 的检查,确保只有在 Debug 构建类型下才添加测试目录。这是一个合理的改动,但需要确保测试在非 Debug 构建类型下不会影响构建流程。

是否建议立即修改:

  • 是,需要确认 BUILD_TESTS 选项的默认值更改是否符合预期,并确保测试目录的添加逻辑不会引入任何问题。

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 5, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 0ef7071 into linuxdeepin:master Aug 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants