Skip to content

add ET file format support#49

Merged
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
Johnson-zs:master
Dec 1, 2025
Merged

add ET file format support#49
deepin-bot[bot] merged 2 commits intolinuxdeepin:masterfrom
Johnson-zs:master

Conversation

@Johnson-zs
Copy link
Contributor

No description provided.

Added support for ET files (.et extension) to be parsed as Excel files
in docparser.cpp. This change allows WPS Office ET spreadsheet files to
be processed by the same Excel parsing logic already in place for .xls
and .xlsx files.

Log: Added support for WPS Office ET spreadsheet files

Influence:
1. Test opening and parsing .et files with Excel content
2. Verify compatibility with existing Excel parsing features
3. Ensure no regression for other file formats
4. Test mixed environments with .et, .xls and .xlsx files

feat: 添加ET文件格式支持

在docparser.cpp中添加了对ET文件(.et扩展名)的支持,将其作为Excel文件解
析。此变更允许WPS Office ET电子表格文件通过已有的.xls和.xlsx文件的相同
Excel解析逻辑进行处理。

Log: 新增WPS Office ET电子表格文件支持

Influence:
1. 测试打开和解析包含Excel内容的.et文件
2. 验证与现有Excel解析功能的兼容性
3. 确保其他文件格式不受影响
4. 测试混合使用.et、.xls和.xlsx文件的环境
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

TAG Bot

TAG: 1.0.25
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这段 git diff 进行审查:

  1. 语法逻辑:
  • 代码修改在语法上是正确的,在 unordered_map 中添加了一个新的键值对
  • 修改符合 C++ 语法规范
  1. 代码质量:
  • 优点:
    • 修改简洁明了,只添加了一行代码
    • 遵循了现有的命名和格式约定
    • 位置合理,与其他 Excel 相关格式放在一起
  • 建议:
    • 建议在 changelog 中添加更详细的 ET 文件格式说明
    • 可以考虑在代码注释中说明 ET 是 WPS Office 的电子表格格式
  1. 代码性能:
  • 对性能没有负面影响,因为 unordered_map 的插入操作是 O(1) 平均时间复杂度
  • 在编译时就初始化的静态 map,运行时性能影响可以忽略
  1. 代码安全:
  • 修改是安全的,没有引入新的安全风险
  • 使用了已有的 createExcel 函数,复用了现有的代码逻辑

改进建议:

  1. 建议在 changelog 中添加更详细的描述,比如:

    * add ET file format support (WPS Office spreadsheet format)
    
  2. 考虑添加注释说明 ET 格式:

    { "et", createExcel },  // WPS Office spreadsheet format
  3. 如果这个修改涉及新的依赖项,建议在相关文档中说明

  4. 建议添加相应的单元测试来验证 ET 文件格式的解析功能

总体来说,这是一个简单且合理的修改,代码质量良好,没有明显的问题。

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 1, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 7702879 into linuxdeepin:master Dec 1, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants