fix: remove fallback to file mode in DConfig#546
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Mar 5, 2026
Merged
fix: remove fallback to file mode in DConfig#546deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
1. Removed the fallback mechanism from DBus mode to file mode in DConfig 2. DConfig now only supports DBus mode by default without falling back to file mode 3. This prevents applications from creating directories when calling interfaces during image building The change removes the automatic fallback to FileBackend when DBusBackend is unavailable. Previously, if DBus service wasn't available, DConfig would fall back to file mode which could cause directory creation during container/image building. Now it will only use DBus mode or fail if DBus is unavailable. Influence: 1. Test DConfig initialization when DBus service is available 2. Verify DConfig fails gracefully when DBus service is unavailable 3. Test that no directories are created during container/image building scenarios 4. Verify existing DBus-based configurations continue to work correctly 5. Test application behavior when DConfig cannot initialize due to missing DBus fix: 移除 DConfig 中回退到文件模式的机制 1. 移除了 DConfig 中从 DBus 模式回退到文件模式的机制 2. DConfig 现在默认只支持 DBus 模式,不会回退到文件模式 3. 这可以防止在构建镜像时,应用程序调用接口去创建目录 此更改移除了当 DBusBackend 不可用时自动回退到 FileBackend 的机制。之前, 如果 DBus 服务不可用,DConfig 会回退到文件模式,这可能导致在容器/镜像构 建期间创建目录。现在它只会使用 DBus 模式,或者在 DBus 不可用时失败。 Influence: 1. 测试当 DBus 服务可用时的 DConfig 初始化 2. 验证当 DBus 服务不可用时 DConfig 优雅地失败 3. 测试在容器/镜像构建场景下不会创建目录 4. 验证现有的基于 DBus 的配置继续正常工作 5. 测试由于缺少 DBus 导致 DConfig 无法初始化时的应用程序行为 PMS: BUG-312173
Contributor
deepin pr auto review针对这段 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
改进建议
总结:这段修改主要涉及系统架构的健壮性和容错性。除非有明确的架构升级需求(如废弃文件配置),否则建议恢复被删除的代码块,以维持系统在 DBus 不可用时的降级服务能力。 |
BLumia
approved these changes
Mar 5, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to file mode
interfaces during image building
The change removes the automatic fallback to FileBackend when
DBusBackend is unavailable. Previously, if DBus service wasn't
available, DConfig would fall back to file mode which could cause
directory creation during container/image building. Now it will only use
DBus mode or fail if DBus is unavailable.
Influence:
scenarios
missing DBus
fix: 移除 DConfig 中回退到文件模式的机制
此更改移除了当 DBusBackend 不可用时自动回退到 FileBackend 的机制。之前,
如果 DBus 服务不可用,DConfig 会回退到文件模式,这可能导致在容器/镜像构
建期间创建目录。现在它只会使用 DBus 模式,或者在 DBus 不可用时失败。
Influence:
PMS: BUG-312173