Skip to content

Fix two printCount bugs#126

Merged
rb-union merged 2 commits intolinuxdeepin:masterfrom
rb-union:fix_bugs
Feb 2, 2024
Merged

Fix two printCount bugs#126
rb-union merged 2 commits intolinuxdeepin:masterfrom
rb-union:fix_bugs

Conversation

@rb-union
Copy link
Contributor

@rb-union rb-union commented Feb 2, 2024

fix: Limit input printCount range

The input printCount may be lessthan -1,
cause incorrect print behavior.
Add check, printCount = 0 when input value < -1.

Log: Limit input printCount range
Bug: https://pms.uniontech.com/bug-view-241777.html

fix: printCount not decrease on low dtk version

On low dtk verison, dprintpreviewdialog return same value
whatever accept/reject. dtk fixes it in 5.6.9
Add print flag on paint function() to detect print behavior
on low verion.

Log: Fix printCount not decrease on low dtk version
Bug: https://pms.uniontech.com/bug-view-241949.html

The input printCount may be lessthan -1,
cause incorrect print behavior.
Add check, printCount = 0 when input value < -1.

Log: Limit input printCount range
Bug: https://pms.uniontech.com/bug-view-241777.html
On low dtk verison, dprintpreviewdialog return same value
whatever accept/reject. dtk fixes it in 5.6.9
Add print flag on paint function() to detect print behavior
on low verion.

Log: Fix printCount not decrease on low dtk version
Bug: https://pms.uniontech.com/bug-view-241949.html
Copy link
Contributor

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit 1fa9bc5 into linuxdeepin:master Feb 2, 2024
rb-union added a commit to rb-union/image-editor that referenced this pull request Feb 5, 2024
rb-union added a commit that referenced this pull request Feb 5, 2024
Bump version to 1.0.42
PR:
* #115
* #119
* #122
* #123
* #124
* #125
* #126

Log: Bump version to 1.0.42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants