fix: resolve library versioning and installation path issues#485
Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom Aug 4, 2025
Merged
fix: resolve library versioning and installation path issues#485zccrs merged 1 commit intolinuxdeepin:masterfrom
zccrs merged 1 commit intolinuxdeepin:masterfrom
Conversation
There was a problem hiding this comment.
Hey @wineee - I've reviewed your changes - here's some feedback:
- Confirm that CMAKE_PROJECT_VERSION and PROJECT_VERSION_MAJOR are defined at the top level and correctly reflect your intended VERSION and SOVERSION; if modules require independent versioning, consider module-specific variables.
- After removing the manual QML install directives, verify that all QML assets are still being installed—consider using qt_install_qml_modules for a more consistent install workflow.
- Rather than relying solely on pkg-config for XCB, explore using official CMake targets (e.g., xcb::xcb) if available to improve portability and downstream consumption.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Confirm that CMAKE_PROJECT_VERSION and PROJECT_VERSION_MAJOR are defined at the top level and correctly reflect your intended VERSION and SOVERSION; if modules require independent versioning, consider module-specific variables.
- After removing the manual QML install directives, verify that all QML assets are still being installed—consider using qt_install_qml_modules for a more consistent install workflow.
- Rather than relying solely on pkg-config for XCB, explore using official CMake targets (e.g., xcb::xcb) if available to improve portability and downstream consumption.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR improves build and installation by applying proper VERSION/SOVERSION metadata to shared libraries, removing redundant QML install directives and obsolete commented code, and enhancing libtreeland’s X11 support by linking against XCB. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
1. Add proper versioning to libtreeland and capture module with VERSION and SOVERSION properties 2. Remove duplicate and unnecessary qml directory installation commands that were causing conflicts 3. Add XCB dependency to libtreeland target_link_libraries for improved X11 compatibility 4. Clean up commented-out installation code that was no longer needed fix: 解决库版本和安装路径问题 1. 为 libtreeland 和 capture 模块添加正确的版本信息,使用 VERSION 和 SOVERSION 属性 2. 移除导致冲突的重复 qml 目录安装命令 3. 在 libtreeland 的 target_link_libraries 中添加 XCB 依赖以提升 X11 兼 容性 4. 清理不再需要的注释掉的安装代码
zccrs
approved these changes
Aug 4, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 解决库版本和安装路径问题
Summary by Sourcery
Fix library versioning and installation path issues by adding proper version properties to CMake targets, removing conflicting QML install steps, and updating link dependencies
Bug Fixes:
Enhancements:
Chores: