Skip to content

fix: resolve library versioning and installation path issues#485

Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:debian
Aug 4, 2025
Merged

fix: resolve library versioning and installation path issues#485
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:debian

Conversation

@wineee
Copy link
Member

@wineee wineee commented Aug 4, 2025

  1. Add proper versioning to libtreeland and capture module with VERSION and SOVERSION properties
  2. Remove duplicate and unnecessary qml directory installation commands that were causing conflicts
  3. Add XCB dependency to libtreeland target_link_libraries for improved X11 compatibility
  4. Clean up commented-out installation code that was no longer needed

fix: 解决库版本和安装路径问题

  1. 为 libtreeland 和 capture 模块添加正确的版本信息,使用 VERSION 和 SOVERSION 属性
  2. 移除导致冲突的重复 qml 目录安装命令
  3. 在 libtreeland 的 target_link_libraries 中添加 XCB 依赖以提升 X11 兼 容性
  4. 清理不再需要的注释掉的安装代码

Summary by Sourcery

Fix library versioning and installation path issues by adding proper version properties to CMake targets, removing conflicting QML install steps, and updating link dependencies

Bug Fixes:

  • Add VERSION and SOVERSION properties to libtreeland and capture modules to enforce proper library versioning
  • Remove duplicate QML directory installation commands to eliminate installation conflicts

Enhancements:

  • Link XCB in libtreeland target_link_libraries to improve X11 compatibility

Chores:

  • Remove commented-out and outdated installation code

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wineee - I've reviewed your changes - here's some feedback:

  • Confirm that CMAKE_PROJECT_VERSION and PROJECT_VERSION_MAJOR are defined at the top level and correctly reflect your intended VERSION and SOVERSION; if modules require independent versioning, consider module-specific variables.
  • After removing the manual QML install directives, verify that all QML assets are still being installed—consider using qt_install_qml_modules for a more consistent install workflow.
  • Rather than relying solely on pkg-config for XCB, explore using official CMake targets (e.g., xcb::xcb) if available to improve portability and downstream consumption.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Confirm that CMAKE_PROJECT_VERSION and PROJECT_VERSION_MAJOR are defined at the top level and correctly reflect your intended VERSION and SOVERSION; if modules require independent versioning, consider module-specific variables.
- After removing the manual QML install directives, verify that all QML assets are still being installed—consider using qt_install_qml_modules for a more consistent install workflow.
- Rather than relying solely on pkg-config for XCB, explore using official CMake targets (e.g., xcb::xcb) if available to improve portability and downstream consumption.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 4, 2025

Reviewer's Guide

This PR improves build and installation by applying proper VERSION/SOVERSION metadata to shared libraries, removing redundant QML install directives and obsolete commented code, and enhancing libtreeland’s X11 support by linking against XCB.

File-Level Changes

Change Details Files
Introduce library versioning metadata
  • Add VERSION property to libtreeland target
  • Add SOVERSION property to libtreeland target
  • Add VERSION property to capture module target
  • Add SOVERSION property to capture module target
src/CMakeLists.txt
src/modules/capture/CMakeLists.txt
Streamline QML installation setup
  • Remove duplicate QML directory install command
  • Delete commented-out QML install directives
  • Remove outdated binary include directory reference
src/CMakeLists.txt
src/modules/capture/CMakeLists.txt
Enhance X11 compatibility
  • Link libtreeland against PkgConfig::XCB
src/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

1. Add proper versioning to libtreeland and capture module with VERSION
and SOVERSION properties
2. Remove duplicate and unnecessary qml directory installation commands
that were causing conflicts
3. Add XCB dependency to libtreeland target_link_libraries for improved
X11 compatibility
4. Clean up commented-out installation code that was no longer needed

fix: 解决库版本和安装路径问题

1. 为 libtreeland 和 capture 模块添加正确的版本信息,使用 VERSION 和
SOVERSION 属性
2. 移除导致冲突的重复 qml 目录安装命令
3. 在 libtreeland 的 target_link_libraries 中添加 XCB 依赖以提升 X11 兼
容性
4. 清理不再需要的注释掉的安装代码
@wineee wineee marked this pull request as draft August 4, 2025 09:26
@wineee wineee marked this pull request as ready for review August 4, 2025 09:29
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wineee - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zccrs zccrs merged commit ce2c405 into linuxdeepin:master Aug 4, 2025
13 of 15 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wineee wineee deleted the debian branch August 4, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants