fix(waylib): the screen flickering issue during screencopy

[zzxyb]

Added resetGlState() call immediately after ending frame to ensure correct OpenGL state before committing outputs in doRender(), improving GPU context handling, prevent gles2-render exception in wlroots.

Log:

Summary by Sourcery

Bug Fixes:

• Call resetGlState immediately after rc()->endFrame instead of after commits to prevent screen flickering and gles2-render exceptions in wlroots

[sourcery-ai]

Reviewer's Guide

This PR refactors the placement of the OpenGL state reset to immediately follow frame completion, ensuring a consistent GPU context before committing outputs and eliminating redundant calls to prevent screen flickering and GLES2-render errors in wlroots.

Sequence diagram for updated OpenGL state reset in doRender()

sequenceDiagram
    participant doRender
    participant rc as Renderer Context
    participant resetGlState
    participant OutputCommit

    doRender->>rc: endFrame()
    doRender->>resetGlState: resetGlState()
    doRender->>OutputCommit: commit outputs (if doCommit)

Loading

Class diagram for WOutputRenderWindowPrivate::doRender() OpenGL state handling

classDiagram
    class WOutputRenderWindowPrivate {
        +void doRender(QList<OutputHelper*>, bool doCommit)
    }
    class RendererContext {
        +void endFrame()
    }
    class OutputHelper {
        +bool commit(...)
    }
    WOutputRenderWindowPrivate --> RendererContext : uses
    WOutputRenderWindowPrivate --> OutputHelper : commits
    WOutputRenderWindowPrivate : +resetGlState()

Loading

File-Level Changes

Change	Details	Files
Refactor placement of resetGlState call to ensure correct GL state before commit and remove redundant reset	Insert resetGlState() immediately after endFrame() Delete the prior resetGlState() invocation following the commit block	waylib/src/server/qtquick/woutputrenderwindow.cpp

Possibly linked issues

• fix: crash when popup window show #24: The PR's fix in doRender addresses GPU context and wlroots exceptions, likely preventing the rendering crash in the issue.
• Init repository #1: PR adds resetGlState() in doRender() to fix rendering crash seen in issue's stack trace.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @zzxyb - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zccrs, zzxyb

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment