Skip to content

修复多屏崩溃#572

Merged
zccrs merged 2 commits intolinuxdeepin:masterfrom
Dami-star:multi-output
Sep 26, 2025
Merged

修复多屏崩溃#572
zccrs merged 2 commits intolinuxdeepin:masterfrom
Dami-star:multi-output

Conversation

@Dami-star
Copy link
Collaborator

@Dami-star Dami-star commented Sep 24, 2025

1、enhance output validation in restore copy mode
2、Delete useless display text in copy mode

Summary by Sourcery

Validate the target output in restore copy mode to prevent invalid access and remove redundant UI text in copy mode.

Bug Fixes:

  • Validate that the target output exists before restoring copy mode and return an error if it doesn't.

Enhancements:

  • Remove the unnecessary "duplicate of the primary screen" label from the copy mode UI.

@Dami-star Dami-star requested review from wineee and zccrs and removed request for wineee September 24, 2025 09:05
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dami-star

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Dami-star Dami-star requested a review from wineee September 24, 2025 09:05
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR strengthens the restore copy mode by validating the target output exists before proceeding and cleans up the copy mode UI by removing an unnecessary text element.

File-Level Changes

Change Details Files
Add existence check for target output in restore copy mode
  • Extract targetName from virtual_output
  • Verify targetName against m_outputList using any_of
  • Send error and return early if validation fails
src/seat/helper.cpp
Remove unused copy mode display text in QML
  • Delete Text element showing duplicate-screen message
src/core/qml/CopyOutput.qml

Possibly linked issues

  • Init repository #1: The PR enhances output validation in onRestoreCopyOutput to prevent multi-screen crashes when handling virtual outputs.
  • #0: PR enhances output validation in restore copy mode, directly preventing crashes when an output is missing, addressing the reported crash.
  • Init repository #1: The PR enhances output validation when restoring copy output, which fixes the crash occurring when moving windows between dual screens.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add invalid output detection to prevent crashes
Remove debug display text in copy mode
@zccrs zccrs merged commit 5b4d7b5 into linuxdeepin:master Sep 26, 2025
8 of 10 checks passed
@Dami-star Dami-star mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants