fix: add missing rendering flags to WSGRenderFootprintNode#719
Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom Jan 30, 2026
Merged
fix: add missing rendering flags to WSGRenderFootprintNode#719zccrs merged 1 commit intolinuxdeepin:masterfrom
zccrs merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds the missing DepthAwareRendering and OpaqueRendering flags to WSGRenderFootprintNode so it is treated as an opaque, depth-aware footprint node and no longer triggers incorrect alpha blending in Qt’s scene graph renderer. Class diagram for updated WSGRenderFootprintNode rendering flagsclassDiagram
class QSGRenderNode {
<<QtClass>>
+RenderingFlags NoExternalRendering
+RenderingFlags BoundedRectRendering
+RenderingFlags DepthAwareRendering
+RenderingFlags OpaqueRendering
+RenderingFlags flags()
}
class WSurfaceItemContent {
<<QtObject>>
}
class WSGRenderFootprintNode {
<<RenderNode>>
-QPointer~WSurfaceItemContent~ m_owner
+RenderingFlags flags()
}
QSGRenderNode <|-- WSGRenderFootprintNode
WSGRenderFootprintNode ..> WSurfaceItemContent : owns
class RenderingFlags {
<<enum>>
NoExternalRendering
BoundedRectRendering
DepthAwareRendering
OpaqueRendering
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the scene graph render node flags for WSGRenderFootprintNode so that Qt’s renderer treats it as an opaque, depth-aware node, fixing incorrect alpha handling (especially for XRGB8888 buffers).
Changes:
- Updated
WSGRenderFootprintNode::flags()to includeDepthAwareRenderingandOpaqueRendering. - Kept existing
NoExternalRenderingandBoundedRectRenderingsemantics while refining how the node participates in the render pipeline. - Ensures the footprint node is treated as a non-alpha, depth-aware marker to avoid unintended blending of otherwise opaque windows.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
wineee
previously approved these changes
Jan 30, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add DepthAwareRendering and OpaqueRendering flags to WSGRenderFootprintNode to prevent incorrect alpha channel handling. Without DepthAwareRendering, Qt forcibly treats all nodes as having alpha channels, causing nodes that should be opaque to render as semi- transparent. This particularly affects windows with XRGB8888 buffer format, which were incorrectly rendered as transparent. While this appears to be a Qt rendering bug, WSGRenderFootprintNode should have these flags set correctly since it performs no actual rendering and should not produce side effects. The node acts as a footprint marker only and should be treated as opaque and depth-aware. Technical details: - Added DepthAwareRendering flag to enable proper depth handling - Added OpaqueRendering flag to indicate no alpha channel - This prevents Qt's renderer from treating the node as requiring alpha blending - Debug method: Use QSG_RENDERER_DEBUG=render;noalpha environment variable to verify alpha node detection Influence: 1. Test XRGB8888 format windows to verify they render as opaque instead of transparent 2. Verify windows with actual alpha channels (ARGB8888) still render correctly 3. Test depth ordering of overlapping windows to ensure proper layering 4. Use QSG_RENDERER_DEBUG=render to verify nodes are not incorrectly flagged as alpha 5. Test various window buffer formats (XRGB8888, ARGB8888, RGB565) for correct rendering 6. Verify no visual regression in transparent window rendering 7. Check performance impact on rendering pipeline with the additional flags fix: 为 WSGRenderFootprintNode 添加缺失的渲染标志 为 WSGRenderFootprintNode 添加 DepthAwareRendering 和 OpaqueRendering 标 志以防止错误的 alpha 通道处理。缺少 DepthAwareRendering 会导致 Qt 强制将 所有节点视为具有 alpha 通道，使本应不透明的节点被渲染为半透明。这特别影 响使用 XRGB8888 缓冲区格式的窗口，这些窗口会被错误地渲染为透明。 虽然这似乎是 Qt 渲染器的 bug，但 WSGRenderFootprintNode 应该正确设置这 些标志，因为它本身不执行任何实际渲染，不应产生副作用。该节点仅作为占位标 记，应被视为不透明和深度感知的。 技术细节： - 添加 DepthAwareRendering 标志以启用正确的深度处理 - 添加 OpaqueRendering 标志以指示无 alpha 通道 - 防止 Qt 渲染器将节点视为需要 alpha 混合 - 调试方法：使用 QSG_RENDERER_DEBUG=render;noalpha 环境变量验证 alpha 节 点检测 Influence: 1. 测试 XRGB8888 格式窗口，验证它们渲染为不透明而非透明 2. 验证具有实际 alpha 通道的窗口（ARGB8888）仍能正确渲染 3. 测试重叠窗口的深度排序，确保正确的层次关系 4. 使用 QSG_RENDERER_DEBUG=render 验证节点未被错误标记为 alpha 5. 测试各种窗口缓冲区格式（XRGB8888、ARGB8888、RGB565）的正确渲染 6. 验证透明窗口渲染无视觉回归 7. 检查额外标志对渲染管线的性能影响
|
TAG Bot New tag: 0.8.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DepthAwareRendering and OpaqueRendering flags to WSGRenderFootprintNode to prevent incorrect alpha channel handling. Without DepthAwareRendering, Qt forcibly treats all nodes as having alpha channels, causing nodes that should be opaque to render as semi- transparent. This particularly affects windows with XRGB8888 buffer format, which were incorrectly rendered as transparent.
While this appears to be a Qt rendering bug, WSGRenderFootprintNode should have these flags set correctly since it performs no actual rendering and should not produce side effects. The node acts as a footprint marker only and should be treated as opaque and depth-aware.
Technical details:
Influence:
fix: 为 WSGRenderFootprintNode 添加缺失的渲染标志
为 WSGRenderFootprintNode 添加 DepthAwareRendering 和 OpaqueRendering 标 志以防止错误的 alpha 通道处理。缺少 DepthAwareRendering 会导致 Qt 强制将 所有节点视为具有 alpha 通道，使本应不透明的节点被渲染为半透明。这特别影
响使用 XRGB8888 缓冲区格式的窗口，这些窗口会被错误地渲染为透明。
虽然这似乎是 Qt 渲染器的 bug，但 WSGRenderFootprintNode 应该正确设置这 些标志，因为它本身不执行任何实际渲染，不应产生副作用。该节点仅作为占位标
记，应被视为不透明和深度感知的。
技术细节：
Influence:
Summary by Sourcery
Bug Fixes: