Skip to content

chore: disable restrictive systemd security options#724

Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:cmake-fix
Jan 31, 2026
Merged

chore: disable restrictive systemd security options#724
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:cmake-fix

Conversation

@wineee
Copy link
Member

@wineee wineee commented Jan 31, 2026

Disabled several restrictive systemd security options in Treeland service to resolve stability issues:

  1. Commented out MemoryDenyWriteExecute=true due to crashes observed on arm64 VMs in libgallium.so during output enabling
  2. Commented out PrivateIPC=true due to mount namespace setup failures with /dev/mqueue permission errors
  3. Commented out ProtectSystem=full due to X11 socket ownership issues with /tmp/.X11-unix

These changes are necessary to maintain system stability while investigating the root causes of these security feature conflicts.

禁用了 Treeland 服务中的几个限制性 systemd 安全选项以解决稳定性问题:

  1. 注释掉 MemoryDenyWriteExecute=true,因为在 arm64 虚拟机上观察到在输出 启用期间 libgallium.so 中发生崩溃
  2. 注释掉 PrivateIPC=true,因为 /dev/mqueue 权限错误导致挂载命名空间设置 失败
  3. 注释掉 ProtectSystem=full,因为 /tmp/.X11-unix 的 X11 套接字所有权 问题

Summary by Sourcery

Enhancements:

  • Disable several restrictive systemd security options in the Treeland systemd service unit to improve runtime stability while underlying compatibility issues are investigated.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 31, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR relaxes several systemd hardening options in the Treeland service unit by commenting out specific directives that have been causing runtime and namespace issues on certain environments, particularly arm64 VMs and X11 setups.

File-Level Changes

Change Details Files
Relax systemd security hardening for the Treeland service unit to avoid crashes and namespace setup failures.
  • Commented out MemoryDenyWriteExecute=true to prevent crashes in libgallium.so on arm64 during output enablement
  • Commented out PrivateIPC=true to avoid mount namespace setup failures related to /dev/mqueue permissions
  • Commented out ProtectSystem=full to work around X11 socket ownership problems for /tmp/.X11-unix
misc/systemd/dde-session-pre.target.wants/treeland.service.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Disabled several restrictive systemd security options in Treeland
service to resolve stability issues:
1. Commented out MemoryDenyWriteExecute=true due to crashes observed on
arm64 VMs in libgallium.so during output enabling
2. Commented out PrivateIPC=true due to mount namespace setup failures
with /dev/mqueue permission errors
3. Commented out ProtectSystem=full due to X11 socket ownership issues
with /tmp/.X11-unix

These changes are necessary to maintain system stability while
investigating the root causes of these security feature conflicts.

禁用了 Treeland 服务中的几个限制性 systemd 安全选项以解决稳定性问题:
1. 注释掉 MemoryDenyWriteExecute=true,因为在 arm64 虚拟机上观察到在输出
启用期间 libgallium.so 中发生崩溃
2. 注释掉 PrivateIPC=true,因为 /dev/mqueue 权限错误导致挂载命名空间设置
失败
3. 注释掉 ProtectSystem=full,因为 /tmp/.X11-unix 的 X11 套接字所有权
问题
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit dad9c1b into linuxdeepin:master Jan 31, 2026
8 checks passed
@wineee wineee deleted the cmake-fix branch February 2, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants