Skip to content

Conversation

@dorianim
Copy link
Member

@dorianim dorianim commented Apr 8, 2022

This PR adds some unittests. They are meant to test the intended functionality of the code but do not test it in a real scenario, only by using mocks (otherwise it would be integration tests).

Codecov:


Fixes #36

Needs to be tested:

  • computer
  • environment
  • fileHelper
  • gpo
  • hooks
  • localUserHelper
  • logging
  • printers
  • realm
  • templates
  • user
  • setup
  • shares
  • imageHelper
  • keytab
  • ldapHelper

Not tested for now:

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dorianim dorianim mentioned this pull request Apr 9, 2022
21 tasks
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Apr 9, 2022

Code Climate has analyzed commit cf60b95 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@dorianim dorianim added the technical dept Technichal dept label Sep 15, 2022
@dorianim dorianim self-assigned this Sep 15, 2022
@dorianim dorianim added this to the 1.0.9 milestone Sep 15, 2022
@dorianim dorianim marked this pull request as ready for review November 13, 2025 19:56
@dorianim dorianim merged commit dfe75cc into master Nov 13, 2025
3 checks passed
@dorianim dorianim deleted the feat/tests branch November 13, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical dept Technichal dept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write unit tests

3 participants