Besser Auffindbarkeit bei Angabe eines Domainnamens... #78
Conversation
Besser Auffindbarkeit bei Angabe eines Domainnamens...
Besser Auffindbarkeit bei Angabe eines Domainnamens...
|
Hi @highTowerSU , |
|
Closing duento inactivity. Feel free to ping me if you want to continue working on this pr. |
|
Hi @dorianim, this PR addresses an issue on some clients where srv.linuxmuster.lan resolves correctly, but the search domain (lookup on srv) does not always resolve as expected. |
dorianim
left a comment
dorianim
left a comment
There was a problem hiding this comment.
Ok, I understand. I have added some comments, please fix them, then we can merge :)
| :rtype: tuple | ||
| """ | ||
| result = subprocess.run("realm discover --name-only", stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True, shell=True) | ||
| result = subprocess.run("realm discover --name-only '" + domain + "'", stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True, shell=True) |
There was a problem hiding this comment.
This will cause an error when domain is None.
| def _readConfigFromString(string): | ||
| configParser = configparser.ConfigParser() | ||
| configParser.read_string(string) | ||
| return configParser |
There was a problem hiding this comment.
Please avoid these kind of changes.
| logging.info(f"* {obsoleteDirectory}") | ||
| fileHelper.deleteDirectory(obsoleteDirectory) | ||
|
|
||
| return True |
There was a problem hiding this comment.
Please avoid these kind of changes.
| def discoverDomains(domain=None): | ||
| """ | ||
| Searches for avialable domains on the current network | ||
| Searches for avialable domains on the current network"realm discover --name-only '" + domain + "'" |
There was a problem hiding this comment.
Please revert or change to a normal sentence. Like this, it does not add any valuable information to the comment.
|
Implemented in 3d06523 |
3 participants
Description
Besser Auffindbarkeit bei Angabe eines Domainnamens...
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Live Tested
Checklist: