Add option to disable creation of complete and incomplete folders

Could you please add a ENV to disable the creation of complete & incomplete folders in downloads?

[queeup]

Also watch dir pls.

[wfg]

It's not as slick as setting a variable, but I actually just wrote a script that does several things on container start including remove those directories. You just create /config/custom-cont-init.d and throw this in there. Then, every time a linuxserver/transmission container starts, this script will run and remove the directories. I named mine 10-cleanup, but you can call it whatever you like.

#!/usr/bin/with-contenv bash

# clean up default directories
echo '[10-cleanup] *** Removing unused directories ***'
rmdir \
    /downloads/complete \
    /downloads/incomplete

Adding /watch to this is trivial.

Just thought I'd share what I'm doing until this is added as a variable. Hope it's useful!

[urda]

@yacht7 while I would have loved this to be a setting in the container your tip was great advice. It was also how I learned how linuxserver allows you to make custom changes which is really slick.

I would still prefer this "option" to be available though as a user.

[mannibis]

@yacht7

I tried following your script advice, but it doesn't seem to work for me. Upon starting the transmission container, "/complete" and "/incomplete" are still created in "/downloads" even though my settings.json file has different directories listed. The setting persists across restarts but those damn default directories are still created.

I created a "custom-cont-init.d" file inside /config and pasted your script above. I saved it and chmod +x'ed it and also chowned it so the user:group would be 911:911. But it doesnt' work. Is there anything else I need to do? Thanks in advance

EDIT: Apologies, I misunderstood. You meant to create a folder named "custom-cont-init.d" and put the script in there! It works now. Thanks again. Now, if I could only figure out how to disable the watch folder. The setting in "settings.json" for watch folder doesn't persist across container restarts. It always defaults to "true". Deleting the folder won't seem to stop Transmission from scanning for new .torrents. Any idea how to disable the watch function at startup?

[wfg]

@mannibis sorry for just now getting to this. Glad you figured it out!

Regarding settings.json: make sure you are only making changes to the file while there's no container running.

[mannibis]

@yacht7 no problem!
However, I still cannot get "watch-dir-enabled": false to stick. Any ideas? Upon re-starting the container it defaults back to true. I am editing settings.json while the container is stopped of course.

[queeup]

You can not do that through settings.json. Watch-dir enabling with startup script.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[abelino]

I've been mounting a volume to override the /defaults/settings.json file. With that approach I am able to define the base default settings and allow the init script to do it's thing i.e. override the username/password. I do believe the dir creation should be handled here but perhaps by grabbing the values from /defaults/settings.json and conditionally creating the incomplete/watch dirs? For example:

/root/etc/cont-init.d/20-config

#!/usr/bin/with-contenv bash

# copy config
[[ ! -f /config/settings.json ]] && cp \
	/defaults/settings.json /config/settings.json

if [ ! -z "$USER" ] && [ ! -z "$PASS" ]; then
	sed -i '/rpc-authentication-required/c\    "rpc-authentication-required": true,' /config/settings.json
	sed -i "/rpc-username/c\    \"rpc-username\": \"$USER\"," /config/settings.json
	sed -i "/rpc-password/c\    \"rpc-password\": \"$PASS\"," /config/settings.json
fi

# update ownership for settings.json
chown abc:abc /config/settings.json

# create downloads folders if it doesn't already exist
settings_path=/defaults/settings.json
download_dir=$(jq '."download-dir"' $settings_path)
if [ ! -d $download_dir ]; then
  mkdir -p $download_dir
fi
chown abc:abc $download_dir

# create incomplete_dir if enabled and update ownership
incomplete_dir_enabled=$(jq '."incomplete-dir-enabled"' $settings_path)
if [[ $incomplete_dir_enabled = 'true' ]]; then
  incomplete_dir=$(jq '."incomplete-dir"' $settings_path)
  mkdir -p $incomplete_dir
  chown abc:abc $incomplete_dir
fi

# create watch_dir if enabled and update ownership
watch_dir_enabled=$(jq '."watch-dir-enabled"' $settings_path)
if [[ $watch_dir_enabled = 'true' ]]; then
  watch_dir=$(jq '."watch-dir"' $settings_path)
  mkdir -p $watch_dir
  chown abc:abc $watch_dir
fi

Something like that. Thoughts?

[johnappletree]

Hi all!
I created a pull-request that should mitigate this issue.
#142

Cheers,
J.

[mathsaey]

@mannibis you cannot disable the watch-dir through the settings as it is passed as a command-line option to transmission-daemon when it is started. I'm not sure why this is done.

If you want to work around this issue, you can put a script in /config/custom-cont-init.d/ with the following content:

#!/bin/bash

# Ensure the watch dir is not automatically enabled
sed -i 's|-c /watch||' /etc/services.d/transmission/run

This will effectively remove the watch-dir command line argument from the script that starts transmission. Be sure to disable the watch-dir in settings.json when the container is shut down before you try it out.

[elisimpson]

@mathsaey thanks for the tip about how to disable watch-dir! This really should be fixed in the code so it doesn't need this hack, but I really appreciate the work-around in the meantime.