-
Notifications
You must be signed in to change notification settings - Fork 0
augmentedreality: add guest users #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d migration cause old one dodi worked for me
glanzel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments App is outdated and should be removed.
The rest looks good to me
| class Scene(models.Model): | ||
| content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE) | ||
| content_type = models.ForeignKey( | ||
| ContentType, on_delete=models.CASCADE, related_name="scenes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shn-liqd This is from one of your changes but I thought it already went to main, does it look alright to you if this is merged as part of my PR or does it suggest something went wrong in git?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ContentType stuff is from @glanzel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glanzel with the more simplified API now, do we still need the scenes related name?
glanzel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Unauthenticated users can now add comments and ratings using an AR endpoint. Leveraging the
django-guest-userlibrary similar to a4-roots, a guest user will be created for them, and labeled as "AR comment" when leaving comments.Uses branch-off of a4 with modified comments-async serializer to achieve comment labeling: liqd/adhocracy4#1802
ST-490