Skip to content

Conversation

@partizipation
Copy link
Contributor

@partizipation partizipation commented Jul 2, 2025

Unauthenticated users can now add comments and ratings using an AR endpoint. Leveraging the django-guest-user library similar to a4-roots, a guest user will be created for them, and labeled as "AR comment" when leaving comments.

Uses branch-off of a4 with modified comments-async serializer to achieve comment labeling: liqd/adhocracy4#1802

ST-490

@partizipation partizipation changed the title WIP augmentedreality: add guest users augmentedreality: add guest users Jul 2, 2025
@partizipation partizipation requested a review from glanzel July 2, 2025 12:15
Copy link
Contributor

@glanzel glanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments App is outdated and should be removed.
The rest looks good to me

class Scene(models.Model):
content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE)
content_type = models.ForeignKey(
ContentType, on_delete=models.CASCADE, related_name="scenes"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shn-liqd This is from one of your changes but I thought it already went to main, does it look alright to you if this is merged as part of my PR or does it suggest something went wrong in git?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ContentType stuff is from @glanzel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glanzel with the more simplified API now, do we still need the scenes related name?

@partizipation partizipation requested review from glanzel and shn-liqd July 2, 2025 15:04
Copy link
Contributor

@glanzel glanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@partizipation partizipation merged commit 2f30747 into main Jul 3, 2025
2 checks passed
@partizipation partizipation deleted the jp-25-05-guest-user-2 branch July 3, 2025 14:17
@partizipation partizipation restored the jp-25-05-guest-user-2 branch July 3, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants