fix: pass OPENCLAW_DOCKER_APT_PACKAGES to podman build#1
Open
fix: pass OPENCLAW_DOCKER_APT_PACKAGES to podman build#1
Conversation
When a skill's SKILL.md frontmatter has name: 12306 (without quotes), YAML parses it as a number instead of a string. This causes TypeError when calling name.startsWith() or name.trim() on a number. This fix adds String() coercion in three places: - bundled-context.ts: skill.name.trim() check - config.ts: allowlist.includes() check - workspace.ts: normalized.includes() check Also adds comprehensive test coverage for numeric skill names. Note: The underlying @mariozechner/pi-coding-agent package has the same issue in validateName() function. Users should quote numeric skill names in YAML (name: "12306") until that package is fixed. Fixes openclaw#35252 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
When blockStreaming is enabled, the deltaBuffer was being reset at message_start without preserving content from the previous turn. This caused text from consecutive API turns (e.g., before and after a tool call) to be concatenated without any separator, producing garbled output like "...with durableNO Fresh session...". This fix adds a "\n\n" separator before resetting the deltaBuffer if it contains content from a previous turn. The separator is added to both deltaBuffer and blockBuffer (or blockChunker) to ensure proper text separation in the streaming UI. After a page refresh, the history renders correctly, confirming this is purely a streaming display issue. Fixes openclaw#35308 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
The previous fix added \n\n before resetAssistantMessageState(), which immediately cleared the separator. This fix: 1. Captures if separator is needed before reset 2. Calls resetAssistantMessageState() to clear buffers 3. Adds separator AFTER reset Fixes PR openclaw#35344 review feedback
When buffer starts with paragraph break (index === 0), keep it instead of stripping it. This ensures cross-turn separator is prepended to next paragraph in flushOnParagraph mode. Added test case for cross-turn separator preservation. Fixes PR openclaw#35344 review feedback
Issue openclaw#35397: setup-podman.sh was not obeying OPENCLAW_DOCKER_APT_PACKAGES environment variable. Now passes it as --build-arg to podman build, matching the behavior of docker-setup.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue openclaw#35397: setup-podman.sh was not obeying OPENCLAW_DOCKER_APT_PACKAGES environment variable. Now passes it as --build-arg to podman build, matching the behavior of docker-setup.sh.