Also check for firstimage by default.#4
Open
rjuju wants to merge 1 commit intolisps:masterfrom
Open
Conversation
|
Great patch and works just fine on Dokuwiki “Igor”. Any change this gets merged into the main branch, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation at https://www.dokuwiki.org/plugin:pageimage mentions:
which includes the first image used in a page. However, the code only check for the first image if the caller explicitly asks for it, which wasn't done. FTR I noticed it because I'm heavily relying on that behavior for one of my setup.