Skip to content

Use dist manifests for publish#27

Merged
gentamura merged 1 commit intomainfrom
fix/publish-dist-directory
Oct 23, 2025
Merged

Use dist manifests for publish#27
gentamura merged 1 commit intomainfrom
fix/publish-dist-directory

Conversation

@gentamura
Copy link
Member

@gentamura gentamura commented Oct 23, 2025

Summary

  • ensure publishConfig points to dist for monorepo packages
  • allows npm tarballs to include semver dependencies generated in dist manifest

Summary by CodeRabbit

  • Chores
    • Updated package publishing configuration to explicitly specify distribution directory settings across multiple packages. This ensures consistent artifact publishing behavior without user-facing changes.

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

Four package.json files across different packages (api, auth, db, types) each receive a new publishConfig.directory property set to "dist", standardizing the distribution directory configuration for npm publishing.

Changes

Cohort / File(s) Change Summary
Publishing configuration updates
packages/api/package.json, packages/auth/package.json, packages/db/package.json, packages/types/package.json
Added publishConfig.directory: "dist" to each file's publishConfig object alongside existing provenance and access settings

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Four packages, one goal so clear,
Dist directories declared with cheer,
Publishing paths now unified,
npm publishes certified! 📦✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Use dist manifests for publish" directly and clearly describes the main change across the pull request. All four modified package.json files (api, auth, db, and types) add a "directory": "dist" property to their publishConfig settings, which aligns perfectly with the title's intent to specify the dist directory for publishing. The title is concise, specific, and accurately reflects the PR objectives of ensuring publishConfig points to the dist directory for monorepo packages. It avoids vague or generic language and provides a teammate with a clear understanding of the primary change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/publish-dist-directory

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ef5955 and d31f6ca.

📒 Files selected for processing (4)
  • packages/api/package.json (1 hunks)
  • packages/auth/package.json (1 hunks)
  • packages/db/package.json (1 hunks)
  • packages/types/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
packages/*/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Reference shared dependencies via the "catalog:" protocol in package manifests

Files:

  • packages/types/package.json
  • packages/auth/package.json
  • packages/api/package.json
  • packages/db/package.json
🔇 Additional comments (4)
packages/api/package.json (1)

5-9: Approved: publishConfig correctly configured for dist publishing.

The publishConfig.directory: "dist" change aligns with the package's existing main/types entries and files array, all pointing to the dist directory. Dependencies correctly follow the coding guideline: external dependencies (hono) use catalog:, and internal workspace dependencies use workspace:^.

packages/db/package.json (1)

5-9: Approved: publishConfig correctly configured for dist publishing.

The publishConfig.directory: "dist" change is properly aligned with the package's main/types entries and files configuration. All external dependencies correctly use the catalog: protocol as per coding guidelines.

packages/types/package.json (1)

5-9: Approved: publishConfig correctly configured for dist publishing.

The publishConfig.directory: "dist" addition is properly aligned with the package's existing main/types and files configuration. The workspace dependency is correctly specified using workspace:^.

packages/auth/package.json (1)

5-9: Approved: publishConfig correctly configured for dist publishing.

The publishConfig.directory: "dist" change is properly aligned with the package's main/types entries and files configuration. All dependencies correctly follow the coding guideline: external dependency (jose) uses catalog:, and internal workspace dependencies use workspace:^.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gentamura gentamura self-assigned this Oct 23, 2025
@gentamura gentamura merged commit b679cef into main Oct 23, 2025
5 checks passed
@gentamura gentamura deleted the fix/publish-dist-directory branch October 23, 2025 14:07
@coderabbitai coderabbitai bot mentioned this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant