add graphql data provider for data query#1038
Merged
jingleizhang merged 85 commits intodevfrom Dec 23, 2022
Merged
Conversation
Collaborator
|
Maybe we need to close and reopen the PR to trigger CI |
DogLi
reviewed
Dec 20, 2022
DogLi
reviewed
Dec 20, 2022
DogLi
reviewed
Dec 20, 2022
| .map_err(|e| Error::RequestError(format!("{:?}", e)))?; | ||
|
|
||
| if let Some(value) = response.data.get("data") { | ||
| let is_hodler_out: IsHodlerOut = serde_json::from_value(value.clone()).unwrap(); |
Contributor
There was a problem hiding this comment.
need to make sure or add some comment that unwrap() is much safe to use here, or return an Invalid data error.
Codecov Report
@@ Coverage Diff @@
## dev #1038 +/- ##
==========================================
- Coverage 20.62% 20.59% -0.04%
==========================================
Files 217 217
Lines 9060 9074 +14
==========================================
Hits 1869 1869
- Misses 7191 7205 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Kailai-Wang
reviewed
Dec 21, 2022
Collaborator
Kailai-Wang
left a comment
Kailai-Wang
left a comment
There was a problem hiding this comment.
I have raised a few questions.
Are the older review comments resolved? If so, we should mark them as "resolved"
Kailai-Wang
approved these changes
Dec 22, 2022
Collaborator
Kailai-Wang
left a comment
Kailai-Wang
left a comment
There was a problem hiding this comment.
Thanks!
Let's not forget we'd need multiple tests once the VC part is done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new data provider graphql interface.
resolves #1030
resolves #1029
resolves #1024