This repository was archived by the owner on Aug 8, 2025. It is now read-only.
Started using timeit for measuring elapsed time#185
Closed
VitalyAssurance wants to merge 1 commit intolitl:masterfrom
VitalyAssurance:use_timeit2
Closed
Started using timeit for measuring elapsed time#185VitalyAssurance wants to merge 1 commit intolitl:masterfrom VitalyAssurance:use_timeit2
timeit for measuring elapsed time#185VitalyAssurance wants to merge 1 commit intolitl:masterfrom
VitalyAssurance:use_timeit2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is some evidence based on Datadog traces that
backofflibrary does not calculate elapsed time correctly. For example, there are occurrences where extra retries are made even though the elapsed time exceeds specifiedmax_timeparameter forbackoff.on_exceptiondecorator. I suspect the problem is due to system clock being adjusted for time drift, or a similar issue.I propose to use
timeitinstead ofdatetime.datetime.now()for measuring elapsed time.