fix(inference): accept numeric STT error codes#1231
Merged
davidzhao merged 4 commits intolivekit:mainfrom Apr 11, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: c90d7db The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Additional reproduction evidence from a downstream integration:
That separation matters because both failure modes can look identical from the client side: “I spoke, but no transcript or useful STT error showed up.” |
davidzhao
approved these changes
Apr 11, 2026
Member
davidzhao
left a comment
There was a problem hiding this comment.
great catch. looking at the server side, it doesn't seem possible for code to be a string
Update the STT error handling to accept numeric codes.
This was referenced Apr 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accept numeric STT error codes in inference server events.
Changes Made
sttErrorEventSchema.codefrom string-only tostring | number429Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
This fixes the schema mismatch reported in #1230.
The bug is that some STT error payloads use numeric codes such as
429. Today those frames failsttServerEventSchema.safeParseAsync(...)and are dropped as parse failures instead of surfacing as STT errors.This PR is intentionally minimal and does not change any retry logic or higher-level error handling.
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.