Skip to content

Fixes #4388: Correct transcription_delay metric calculation in STT turn detec… #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzhao merged 1 commit into from
Jan 21, 2026
Merged

Fixes #4388: Correct transcription_delay metric calculation in STT turn detec… #4396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions livekit-agents/livekit/agents/voice/audio_recognition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ async def _on_stt_event(self, ev: stt.SpeechEvent) -> None:
self._audio_preflight_transcript = ""
self._final_transcript_received.set()

if not self._vad or self._last_speaking_time == 0:
if not self._vad or self._last_speaking_time is None:
# vad disabled, use stt timestamp
# TODO: this would screw up transcription latency metrics
# but we'll live with it for now.
Expand Down Expand Up @@ -425,7 +425,7 @@ async def _on_stt_event(self, ev: stt.SpeechEvent) -> None:
self._audio_preflight_transcript = (self._audio_transcript + " " + transcript).lstrip()
self._audio_interim_transcript = transcript

if not self._vad or self._last_speaking_time == 0:
if not self._vad or self._last_speaking_time is None:
# vad disabled, use stt timestamp
self._last_speaking_time = time.time()

Expand All @@ -449,7 +449,8 @@ async def _on_stt_event(self, ev: stt.SpeechEvent) -> None:

self._speaking = False
self._user_turn_committed = True
self._last_speaking_time = time.time()
if not self._vad or self._last_speaking_time is None:
self._last_speaking_time = time.time()

chat_ctx = self._hooks.retrieve_chat_ctx().copy()
self._run_eou_detection(chat_ctx)
Expand Down
2 changes: 0 additions & 2 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.